components/web_modal/web_contents_modal_dialog_manager.h - Issue 23475022: Add WebContentsModalDialogManager unit tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/web_modal/web_contents_modal_dialog_manager.h

Issue 23475022: Add WebContentsModalDialogManager unit tests (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Simplify fake dialog creation Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/web_modal/web_contents_modal_dialog_manager.h

diff --git a/components/web_modal/web_contents_modal_dialog_manager.h b/components/web_modal/web_contents_modal_dialog_manager.h

index 09115f0b099b70c2c120c6187848f53f26f40de9..5502c09d2180fd039105b00951873a212fd2876c 100644

--- a/components/web_modal/web_contents_modal_dialog_manager.h

+++ b/components/web_modal/web_contents_modal_dialog_manager.h

@@ -38,7 +38,9 @@ class WebContentsModalDialogManager

// WillClose() when it is being destroyed.

void ShowDialog(NativeWebContentsModalDialog dialog);

- // Returns true if a dialog is currently being shown.

+ // Returns true if any dialogs are active and not closed.

+ // TODO(wittman): Give this a better name, since it can return true if no

+ // dialogs are displayed.

bool IsShowingDialog() const;

// Focus the topmost modal dialog. IsShowingDialog() must be true when

« no previous file with comments | « no previous file | components/web_modal/web_contents_modal_dialog_manager_unittest.cc » ('j') | no next file with comments »