Issue 23475022: Add WebContentsModalDialogManager unit tests

Issue 23475022: Add WebContentsModalDialogManager unit tests (Closed)

Created:
7 years, 3 months ago by Mike Wittman

Modified:
7 years, 3 months ago

Reviewers:
sky

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add WebContentsModalDialogManager unit tests Implement additional tests covering most of the functionality of WebContentsModalDialogManager. Refactor common setup into the test fixture. BUG=157161 R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221483

Patch Set 1 #

Total comments: 6

Patch Set 2 : Address comments #

Patch Set 3 : Simplify fake dialog creation #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+271 lines, -38 lines)			Patch
	M	components/web_modal/web_contents_modal_dialog_manager.h	View		1 chunk	+3 lines, -1 line	0 comments	Download
	M	components/web_modal/web_contents_modal_dialog_manager_unittest.cc	View	1 2	2 chunks	+268 lines, -37 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

sky

LGTM https://codereview.chromium.org/23475022/diff/1/components/web_modal/web_contents_modal_dialog_manager_unittest.cc File components/web_modal/web_contents_modal_dialog_manager_unittest.cc (right): https://codereview.chromium.org/23475022/diff/1/components/web_modal/web_contents_modal_dialog_manager_unittest.cc#newcode110 components/web_modal/web_contents_modal_dialog_manager_unittest.cc:110: }; DISALLOW_... https://codereview.chromium.org/23475022/diff/1/components/web_modal/web_contents_modal_dialog_manager_unittest.cc#newcode151 components/web_modal/web_contents_modal_dialog_manager_unittest.cc:151: }; DISALLOW_... https://codereview.chromium.org/23475022/diff/1/components/web_modal/web_contents_modal_dialog_manager_unittest.cc#newcode159 components/web_modal/web_contents_modal_dialog_manager_unittest.cc:159: ...

7 years, 3 months ago (2013-09-05 15:59:12 UTC) #2

Mike Wittman

https://codereview.chromium.org/23475022/diff/1/components/web_modal/web_contents_modal_dialog_manager_unittest.cc File components/web_modal/web_contents_modal_dialog_manager_unittest.cc (right): https://codereview.chromium.org/23475022/diff/1/components/web_modal/web_contents_modal_dialog_manager_unittest.cc#newcode110 components/web_modal/web_contents_modal_dialog_manager_unittest.cc:110: }; On 2013/09/05 15:59:12, sky wrote: > DISALLOW_... Done. ...

7 years, 3 months ago (2013-09-05 18:42:09 UTC) #3

Mike Wittman

7 years, 3 months ago (2013-09-05 19:01:12 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r221483 (presubmit successful).

Expand Messages | Collapse Messages