dart/tools/testing/dart/test_suite.dart - Issue 23475015: Seems like cc/ TestCases don't have a TestInformation object attached

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dart/tools/testing/dart/test_suite.dart

Issue 23475015: Seems like cc/ TestCases don't have a TestInformation object attached (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: dart/tools/testing/dart/test_suite.dart

diff --git a/dart/tools/testing/dart/test_suite.dart b/dart/tools/testing/dart/test_suite.dart

index e05e7ab187f4f70152880260f1df6f99f14c3148..0b6904b50451117bbf0b3a123970f08b78962b45 100644

--- a/dart/tools/testing/dart/test_suite.dart

+++ b/dart/tools/testing/dart/test_suite.dart

@@ -287,8 +287,8 @@ abstract class TestSuite {

// Update Summary report

if (configuration['report']) {

SummaryReport.add(expectations);

- if (testCase.info.hasCompileError &&

+ if (testCase.info != null &&

+ testCase.info.hasCompileError &&

TestUtils.isBrowserRuntime(configuration['runtime']) &&

configuration['compiler'] != 'none') {

SummaryReport.addCompileErrorSkipTest();

« no previous file with comments | « no previous file | no next file » | no next file with comments »