Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: trunk/src/chrome/browser/ui/startup/startup_browser_creator_browsertest.cc

Issue 23475011: Revert 220623 "Update chrome://newtab checks in browser tests to..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/chrome/browser/ui/startup/startup_browser_creator_browsertest.cc
===================================================================
--- trunk/src/chrome/browser/ui/startup/startup_browser_creator_browsertest.cc (revision 220635)
+++ trunk/src/chrome/browser/ui/startup/startup_browser_creator_browsertest.cc (working copy)
@@ -22,7 +22,6 @@
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/profiles/profile_impl.h"
#include "chrome/browser/profiles/profile_manager.h"
-#include "chrome/browser/search/search.h"
#include "chrome/browser/sessions/session_restore.h"
#include "chrome/browser/signin/signin_promo.h"
#include "chrome/browser/ui/browser.h"
@@ -439,8 +438,8 @@
EXPECT_EQ("title1.html",
tab_strip->GetWebContentsAt(0)->GetURL().ExtractFileName());
- EXPECT_TRUE(chrome::IsNTPURL(tab_strip->GetWebContentsAt(1)->GetURL(),
- browser()->profile()));
+ EXPECT_EQ(GURL(chrome::kChromeUINewTabURL),
+ tab_strip->GetWebContentsAt(1)->GetURL());
EXPECT_EQ("title2.html",
tab_strip->GetWebContentsAt(2)->GetURL().ExtractFileName());
EXPECT_EQ(internals::GetWelcomePageURL(),
@@ -466,8 +465,8 @@
EXPECT_EQ(signin::GetPromoURL(signin::SOURCE_START_PAGE, false),
tab_strip->GetWebContentsAt(0)->GetURL());
} else {
- EXPECT_TRUE(chrome::IsNTPURL(tab_strip->GetWebContentsAt(0)->GetURL(),
- browser()->profile()));
+ EXPECT_EQ(GURL(chrome::kChromeUINewTabURL),
+ tab_strip->GetWebContentsAt(0)->GetURL());
}
}
@@ -492,8 +491,8 @@
EXPECT_EQ(signin::GetPromoURL(signin::SOURCE_START_PAGE, false),
tab_strip->GetWebContentsAt(0)->GetURL());
} else {
- EXPECT_TRUE(chrome::IsNTPURL(tab_strip->GetWebContentsAt(0)->GetURL(),
- browser()->profile()));
+ EXPECT_EQ(GURL(chrome::kChromeUINewTabURL),
+ tab_strip->GetWebContentsAt(0)->GetURL());
}
EXPECT_EQ(internals::GetWelcomePageURL(),
tab_strip->GetWebContentsAt(1)->GetURL());
@@ -825,8 +824,8 @@
ASSERT_TRUE(new_browser);
TabStripModel* tab_strip = new_browser->tab_strip_model();
ASSERT_EQ(1, tab_strip->count());
- EXPECT_TRUE(chrome::IsNTPURL(tab_strip->GetWebContentsAt(0)->GetURL(),
- browser()->profile()));
+ EXPECT_EQ(GURL(chrome::kChromeUINewTabURL),
+ tab_strip->GetWebContentsAt(0)->GetURL());
// profile_urls opened the urls.
ASSERT_EQ(1u, chrome::GetBrowserCount(profile_urls, original_desktop_type));
@@ -927,7 +926,7 @@
TabStripModel* tab_strip = new_browser->tab_strip_model();
ASSERT_EQ(1, tab_strip->count());
content::WebContents* web_contents = tab_strip->GetWebContentsAt(0);
- EXPECT_TRUE(chrome::IsNTPURL(web_contents->GetURL(), profile_home));
+ EXPECT_EQ(GURL(chrome::kChromeUINewTabURL), web_contents->GetURL());
EXPECT_EQ(1U,
InfoBarService::FromWebContents(web_contents)->infobar_count());
@@ -939,7 +938,7 @@
tab_strip = new_browser->tab_strip_model();
ASSERT_EQ(1, tab_strip->count());
web_contents = tab_strip->GetWebContentsAt(0);
- EXPECT_TRUE(chrome::IsNTPURL(web_contents->GetURL(), profile_last));
+ EXPECT_EQ(GURL(chrome::kChromeUINewTabURL), web_contents->GetURL());
EXPECT_EQ(1U,
InfoBarService::FromWebContents(web_contents)->infobar_count());
@@ -951,7 +950,7 @@
tab_strip = new_browser->tab_strip_model();
ASSERT_EQ(1, tab_strip->count());
web_contents = tab_strip->GetWebContentsAt(0);
- EXPECT_TRUE(chrome::IsNTPURL(web_contents->GetURL(), profile_urls));
+ EXPECT_EQ(GURL(chrome::kChromeUINewTabURL), web_contents->GetURL());
EXPECT_EQ(1U,
InfoBarService::FromWebContents(web_contents)->infobar_count());
}
@@ -1064,8 +1063,8 @@
// Verify that the NTP and the welcome page are shown.
TabStripModel* tab_strip = new_browser->tab_strip_model();
ASSERT_EQ(2, tab_strip->count());
- EXPECT_TRUE(chrome::IsNTPURL(tab_strip->GetWebContentsAt(0)->GetURL(),
- browser()->profile()));
+ EXPECT_EQ(GURL(chrome::kChromeUINewTabURL),
+ tab_strip->GetWebContentsAt(0)->GetURL());
EXPECT_EQ(internals::GetWelcomePageURL(),
tab_strip->GetWebContentsAt(1)->GetURL());
}
@@ -1252,8 +1251,8 @@
// not been replaced by the sync promo and no sync promo has been added.
TabStripModel* tab_strip = new_browser->tab_strip_model();
ASSERT_EQ(2, tab_strip->count());
- EXPECT_TRUE(chrome::IsNTPURL(tab_strip->GetWebContentsAt(0)->GetURL(),
- browser()->profile()));
+ EXPECT_EQ(GURL(chrome::kChromeUINewTabURL),
+ tab_strip->GetWebContentsAt(0)->GetURL());
EXPECT_EQ("title1.html",
tab_strip->GetWebContentsAt(1)->GetURL().ExtractFileName());
}

Powered by Google App Engine
This is Rietveld 408576698