Revert 220623 "Update chrome://newtab checks in browser tests to..."

Revert 220623 "Update chrome://newtab checks in browser tests to..."

> Update chrome://newtab checks in browser tests to use chrome::IsNTPURL().
> 
> BUG=229009
> TEST=none
> TBR=sky@chromium.org
> 
> Review URL: https://chromiumcodereview.appspot.com/22403003

TBR=kmadhusu@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220636

[dharcourt, 2013-08-30 20:23:16]

Committed patchset #1 manually as r220636.

[kmadhusu, 2013-08-30 20:34:08]

Reason: StartupBrowserCreatorTest.ProfilesWithoutPagesNotLaunched test crashed
on Mac ASAN bot.

Stack trace:
[ RUN      ] StartupBrowserCreatorTest.ProfilesWithoutPagesNotLaunched
[21918:21918:0830/124514:647710648:ERROR:browser_main_loop.cc(167)] Running
without the SUID sandbox! See
https://code.google.com/p/chromium/wiki/LinuxSUIDSandboxDevelopment for more
information on developing with the sandbox on.
=================================================================
==21918==ERROR: AddressSanitizer: heap-use-after-free on address 0x6160000f9a80
at pc 0x18df09b bp 0x7fff0ddbe7f0 sp 0x7fff0ddbe7e8
READ of size 8 at 0x6160000f9a80 thread T0
    #0 0x18df09a in browser
/b/build/slave/Linux_ASAN_Builder/build/src/out/Release/../../chrome/browser/ui/browser.h:234:0
    #1 0x18df09a in
StartupBrowserCreatorTest_ProfilesWithoutPagesNotLaunched_Test::RunTestOnMainThread()
/b/build/slave/Linux_ASAN_Builder/build/src/out/Release/../../chrome/browser/ui/startup/startup_browser_creator_browsertest.cc:828:0
    #2 0x3d888ee in InProcessBrowserTest::RunTestOnMainThreadLoop()
/b/build/slave/Linux_ASAN_Builder/build/src/out/Release/../../chrome/test/base/in_process_browser_test.cc:433:0
    #3 0x7f87d9c in content::BrowserTestBase::ProxyRunTestOnMainThreadLoop()
/b/build/slave/Linux_ASAN_Builder/build/src/out/Release/../../content/public/test/browser_test_base.cc:181:0
    #4 0x2f84420 in Run
/b/build/slave/Linux_ASAN_Builder/build/src/out/Release/../../base/callback.h:396:0
    #5 0x2f84420 in ChromeBrowserMainParts::PreMainMessageLoopRunImpl()
/b/build/slave/Linux_ASAN_Builder/build/src/out/Release/../../chrome/browser/chrome_browser_main.cc:1602:0
    #6 0x2f8121c in ChromeBrowserMainParts::PreMainMessageLoopRun()
/b/build/slave/Linux_ASAN_Builder/build/src/out/Release/../../chrome/browser/chrome_browser_main.cc:1057:0
    #7 0x3e81b94 in content::BrowserMainLoop::PreMainMessageLoopRun()
/b/build/slave/Linux_ASAN_Builder/build/src/out/Release/../../content/browser/browser_main_loop.cc:672:0
    #8 0x41b3a5f in Run
/b/build/slave/Linux_ASAN_Builder/build/src/out/Release/../../base/callback.h:396:0
    #9 0x41b3a5f in content::StartupTaskRunner::RunAllTasksNow()
/b/build/slave/Linux_ASAN_Builder/build/src/out/Release/../../content/browser/startup_task_runner.cc:43:0
    #10 0x3e7e188 in content::BrowserMainLoop::CreateStartupTasks()
/b/build/slave/Linux_ASAN_Builder/build/src/out/Release/../../content/browser/browser_main_loop.cc:574:0
    #11 0x42908f9 in
content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&)
/b/build/slave/Linux_ASAN_Builder/build/src/out/Release/../../content/browser/browser_main_runner.cc:108:0
    #12 0x99007a1 in content::BrowserMain(content::MainFunctionParams const&)
/b/build/slave/Linux_ASAN_Builder/build/src/out/Release/../../content/browser/browser_main.cc:22:0
    #13 0x7f876b2 in content::BrowserTestBase::SetUp()
/b/build/slave/Linux_ASAN_Builder/build/src/out/Release/../../content/public/test/browser_test_base.cc:166:0
    #14 0x3d858cf in InProcessBrowserTest::SetUp()
/b/build/slave/Linux_ASAN_Builder/build/src/out/Release/../../chrome/test/base/in_process_browser_test.cc:224:0
    #15 0x51e5b86 in testing::Test::Run()
/b/build/slave/Linux_ASAN_Builder/build/src/out/Release/../../testing/gtest/src/gtest.cc:2063:0
    #16 0x51e7b1d in testing::TestInfo::Run()
/b/build/slave/Linux_ASAN_Builder/build/src/out/Release/../../testing/gtest/src/gtest.cc:2244:0
    #17 0x51e8ab2 in testing::TestCase::Run()
/b/build/slave/Linux_ASAN_Builder/build/src/out/Release/../../testing/gtest/src/gtest.cc:2351:0
    #18 0x51f63c5 in testing::internal::UnitTestImpl::RunAllTests()
/b/build/slave/Linux_ASAN_Builder/build/src/out/Release/../../testing/gtest/src/gtest.cc:4177:0
    #19 0x51f58fc in
HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>
/b/build/slave/Linux_ASAN_Builder/build/src/out/Release/../../testing/gtest/src/gtest.cc:2051:0
    #20 0x51f58fc in testing::UnitTest::Run()
/b/build/slave/Linux_ASAN_Builder/build/src/out/Release/../../testing/gtest/src/gtest.cc:3809:0
    #21 0x45be4f6 in base::TestSuite::Run()
/b/build/slave/Linux_ASAN_Builder/build/src/out/Release/../../base/test/test_suite.cc:198:0
    #22 0x1c2678f in ChromeTestLauncherDelegate::RunTestSuite(int, char**)
/b/build/slave/Linux_ASAN_Builder/build/src/out/Release/../../chrome/test/base/chrome_test_launcher.cc:61:0
    #23 0x801c772 in content::LaunchTests(content::TestLauncherDelegate*, int,
char**)
/b/build/slave/Linux_ASAN_Builder/build/src/out/Release/../../content/public/test/test_launcher.cc:337:0
    #24 0x1c2669b in main
/b/build/slave/Linux_ASAN_Builder/build/src/out/Release/../../chrome/test/base/chrome_test_launcher.cc:169:0
    #25 0x7fd4e821976c in __libc_start_main
/build/buildd/eglibc-2.15/csu/libc-start.c:226:0
    #26 0x4a97ac in _start ??:0