Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 2347493003: Moves RootWindowController::MoveWindowsTo to WmRootWindowController (Closed)

Created:
4 years, 3 months ago by sky
Modified:
4 years, 3 months ago
Reviewers:
msw
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Moves RootWindowController::MoveWindowsTo to WmRootWindowController This is part of getting shutdown of displays working correctly. BUG=none TEST=covered by tests R=msw@chromium.org Committed: https://crrev.com/7aff7f8db4915cb6365af3f5fc4f7ec145d5f8b2 Cr-Commit-Position: refs/heads/master@{#419037}

Patch Set 1 #

Total comments: 4

Patch Set 2 : merge to trunk #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -99 lines) Patch
M ash/aura/wm_shell_aura.h View 1 chunk +1 line, -0 lines 0 comments Download
M ash/aura/wm_shell_aura.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M ash/common/wm_root_window_controller.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ash/common/wm_root_window_controller.cc View 1 3 chunks +104 lines, -0 lines 0 comments Download
M ash/common/wm_shell.h View 1 chunk +6 lines, -1 line 0 comments Download
M ash/mus/bridge/wm_shell_mus.h View 1 chunk +1 line, -0 lines 0 comments Download
M ash/mus/bridge/wm_shell_mus.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M ash/root_window_controller.cc View 2 chunks +1 line, -98 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
sky
https://codereview.chromium.org/2347493003/diff/1/ash/common/wm_root_window_controller.cc File ash/common/wm_root_window_controller.cc (right): https://codereview.chromium.org/2347493003/diff/1/ash/common/wm_root_window_controller.cc#newcode241 ash/common/wm_root_window_controller.cc:241: void WmRootWindowController::MoveWindowsTo(WmWindow* dest) { This name is mildly confusing ...
4 years, 3 months ago (2016-09-15 03:27:14 UTC) #1
msw
lgtm https://codereview.chromium.org/2347493003/diff/1/ash/common/wm_root_window_controller.cc File ash/common/wm_root_window_controller.cc (right): https://codereview.chromium.org/2347493003/diff/1/ash/common/wm_root_window_controller.cc#newcode241 ash/common/wm_root_window_controller.cc:241: void WmRootWindowController::MoveWindowsTo(WmWindow* dest) { On 2016/09/15 03:27:14, sky ...
4 years, 3 months ago (2016-09-15 17:29:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2347493003/20001
4 years, 3 months ago (2016-09-15 22:45:38 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-15 23:34:57 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 23:36:59 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7aff7f8db4915cb6365af3f5fc4f7ec145d5f8b2
Cr-Commit-Position: refs/heads/master@{#419037}

Powered by Google App Engine
This is Rietveld 408576698