Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(594)

Issue 2347493002: fix DDC build: some inference failures are reported now (Closed)

Created:
4 years, 3 months ago by Jennifer Messerly
Modified:
4 years, 3 months ago
Reviewers:
Leaf
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

fix DDC build: some inference failures are reported now, so we need to update some test type annotations Committed: https://github.com/dart-lang/dev_compiler/commit/1c957d548d53cb0dbea9fc442d68dde5d6126a34

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M pkg/dev_compiler/test/codegen/language/await_for_test.dart View 4 chunks +4 lines, -4 lines 1 comment Download
M pkg/dev_compiler/test/codegen/lib/html/indexeddb_1_test.dart View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 4 (2 generated)
Jennifer Messerly
TBR but examples might be worth a look https://codereview.chromium.org/2347493002/diff/1/pkg/dev_compiler/test/codegen/language/await_for_test.dart File pkg/dev_compiler/test/codegen/language/await_for_test.dart (right): https://codereview.chromium.org/2347493002/diff/1/pkg/dev_compiler/test/codegen/language/await_for_test.dart#newcode59 pkg/dev_compiler/test/codegen/language/await_for_test.dart:59: Future ...
4 years, 3 months ago (2016-09-15 00:33:50 UTC) #2
Jennifer Messerly
4 years, 3 months ago (2016-09-15 00:39:34 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1c957d548d53cb0dbea9fc442d68dde5d6126a34 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698