Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Unified Diff: content/test/gpu/gpu_tests/maps.py

Issue 2347483004: Update the host URLs in WPR archives used by map test (Closed)
Patch Set: Address Ken's comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/test/gpu/page_sets/data/maps.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/test/gpu/gpu_tests/maps.py
diff --git a/content/test/gpu/gpu_tests/maps.py b/content/test/gpu/gpu_tests/maps.py
index c3fbaee011528b10e0f0c781a2a45857515eb1fc..a30e1256512d594676eb5c274309fbc60b1d6c38 100644
--- a/content/test/gpu/gpu_tests/maps.py
+++ b/content/test/gpu/gpu_tests/maps.py
@@ -89,7 +89,7 @@ class MapsValidator(cloud_storage_test_base.ValidatorBase):
class MapsPage(gpu_test_base.PageBase):
def __init__(self, story_set, base_dir, expectations):
super(MapsPage, self).__init__(
- url='http://localhost:8000/performance.html',
+ url='http://map-test/performance.html',
page_set=story_set,
base_dir=base_dir,
name='Maps.maps_004',
@@ -112,11 +112,23 @@ class Maps(cloud_storage_test_base.CloudStorageTestBase):
width and height query args were set to 800 by 600. The WPR was
recorded with:
- tools/perf/record_wpr smoothness_maps --browser=system --upload
-
- Then the maps_???.wpr.sha1 and maps.json were copied from
- tools/perf/page_sets/data into content/test/gpu/page_sets/data. The
- same sha1 file and json file need to be copied into both of these
+ tools/perf/record_wpr smoothness_maps --browser=system
+
+ This would produce maps_???.wpr and maps.json were copied from
+ tools/perf/page_sets/data into content/test/gpu/page_sets/data.
+ It worths noting that telemetry no longer allows replaying URL that has form
+ of local host. If the recording was created for locahost URL, ones can update
+ the host name by running:
+ web-page-replay/httparchive.py remap-host maps_004.wpr \
+ localhost:10020 map-test
+ (web-page-replay/ can be found in third_party/catapult/telemetry/third_party/)
+ After update the host name in WPR archive, please remember to update the host
+ URL in content/test/gpu/gpu_tests/maps.py as well.
+
+ To upload the maps_???.wpr to cloud storage, one would run:
+ depot_tools/upload_to_google_storage.py --bucket=chromium-telemetry \
+ maps_???.wpr
+ The same sha1 file and json file need to be copied into both of these
directories in any CL which updates the recording."""
test = MapsValidator
« no previous file with comments | « no previous file | content/test/gpu/page_sets/data/maps.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698