|
|
Created:
4 years, 3 months ago by nednguyen Modified:
4 years, 3 months ago Reviewers:
Ken Russell (switch to Gerrit) CC:
chromium-reviews, jam, darin-cc_chromium.org, piman+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionUpdate the host URLs in WPR archives used by map test
This is done using:
./httparchive.py remap-host maps_004.wpr localhost:10020 map-test
(https://codereview.chromium.org/2346853003)
BUG=646924
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Committed: https://crrev.com/c582e5311da945d4e123f499be07f3bba2976750
Cr-Commit-Position: refs/heads/master@{#419056}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Address Ken's comments #
Messages
Total messages: 23 (13 generated)
Description was changed from ========== Update map test BUG= ========== to ========== Update map test BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ==========
The CQ bit was checked by nednguyen@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Update map test BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ========== to ========== Update the host URLs in WPR archives used by map test BUG=646924 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ==========
Description was changed from ========== Update the host URLs in WPR archives used by map test BUG=646924 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ========== to ========== Update the host URLs in WPR archives used by map test This is done using: ./httparchive.py remap-host maps_002.wpr localhost:10020 map-test ./httparchive.py remap-host maps_004.wpr localhost:10020 map-test (https://codereview.chromium.org/2346853003) BUG=646924 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ==========
kbr@chromium.org changed reviewers: + kbr@chromium.org
Thanks for putting this together. It looks good overall. Note, we aren't using the maps_002 archive any more, so it could be deleted and/or not updated at all. https://codereview.chromium.org/2347483004/diff/1/content/test/gpu/gpu_tests/... File content/test/gpu/gpu_tests/maps.py (right): https://codereview.chromium.org/2347483004/diff/1/content/test/gpu/gpu_tests/... content/test/gpu/gpu_tests/maps.py:120: directories in any CL which updates the recording.""" Could you please add the postprocessing step above to these instructions, or add any new arguments to record_wpr which should be used to generate the WPR archive properly?
+ynovikov as FYI
On 2016/09/15 17:52:52, Ken Russell wrote: > +ynovikov as FYI +Ken: how do I enable android tryjob which maps test is failing on?
On 2016/09/15 18:02:42, nednguyen wrote: > On 2016/09/15 17:52:52, Ken Russell wrote: > > +ynovikov as FYI > > +Ken: how do I enable android tryjob which maps test is failing on? Look at android_optional_gpu_tests_rel. maps passed, BTW
On 2016/09/15 18:25:55, ynovikov wrote: > On 2016/09/15 18:02:42, nednguyen wrote: > > On 2016/09/15 17:52:52, Ken Russell wrote: > > > +ynovikov as FYI > > > > +Ken: how do I enable android tryjob which maps test is failing on? > > Look at android_optional_gpu_tests_rel. maps passed, BTW Oh, so this is the right fix then. Weird that it fails on my android one device :-/
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Thanks Yuly for testing. Ned, I don't think the Android One runs WebGL properly, or at least the WebGL-based version of Google Maps. This lgtm if you'll update the comment in maps.py about how to regenerate the WPR files.
Description was changed from ========== Update the host URLs in WPR archives used by map test This is done using: ./httparchive.py remap-host maps_002.wpr localhost:10020 map-test ./httparchive.py remap-host maps_004.wpr localhost:10020 map-test (https://codereview.chromium.org/2346853003) BUG=646924 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ========== to ========== Update the host URLs in WPR archives used by map test This is done using: ./httparchive.py remap-host maps_004.wpr localhost:10020 map-test (https://codereview.chromium.org/2346853003) BUG=646924 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ==========
https://codereview.chromium.org/2347483004/diff/1/content/test/gpu/gpu_tests/... File content/test/gpu/gpu_tests/maps.py (right): https://codereview.chromium.org/2347483004/diff/1/content/test/gpu/gpu_tests/... content/test/gpu/gpu_tests/maps.py:120: directories in any CL which updates the recording.""" On 2016/09/15 17:52:18, Ken Russell wrote: > Could you please add the postprocessing step above to these instructions, or add > any new arguments to record_wpr which should be used to generate the WPR archive > properly? Done.
The CQ bit was checked by nednguyen@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org Link to the patchset: https://codereview.chromium.org/2347483004/#ps20001 (title: "Address Ken's comments")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Update the host URLs in WPR archives used by map test This is done using: ./httparchive.py remap-host maps_004.wpr localhost:10020 map-test (https://codereview.chromium.org/2346853003) BUG=646924 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ========== to ========== Update the host URLs in WPR archives used by map test This is done using: ./httparchive.py remap-host maps_004.wpr localhost:10020 map-test (https://codereview.chromium.org/2346853003) BUG=646924 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Update the host URLs in WPR archives used by map test This is done using: ./httparchive.py remap-host maps_004.wpr localhost:10020 map-test (https://codereview.chromium.org/2346853003) BUG=646924 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ========== to ========== Update the host URLs in WPR archives used by map test This is done using: ./httparchive.py remap-host maps_004.wpr localhost:10020 map-test (https://codereview.chromium.org/2346853003) BUG=646924 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Committed: https://crrev.com/c582e5311da945d4e123f499be07f3bba2976750 Cr-Commit-Position: refs/heads/master@{#419056} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/c582e5311da945d4e123f499be07f3bba2976750 Cr-Commit-Position: refs/heads/master@{#419056} |