Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Issue 2347483004: Update the host URLs in WPR archives used by map test (Closed)

Created:
4 years, 3 months ago by nednguyen
Modified:
4 years, 3 months ago
CC:
chromium-reviews, jam, darin-cc_chromium.org, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update the host URLs in WPR archives used by map test This is done using: ./httparchive.py remap-host maps_004.wpr localhost:10020 map-test (https://codereview.chromium.org/2346853003) BUG=646924 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Committed: https://crrev.com/c582e5311da945d4e123f499be07f3bba2976750 Cr-Commit-Position: refs/heads/master@{#419056}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address Ken's comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -12 lines) Patch
M content/test/gpu/gpu_tests/maps.py View 1 2 chunks +18 lines, -6 lines 0 comments Download
M content/test/gpu/page_sets/data/maps.json View 1 1 chunk +3 lines, -6 lines 0 comments Download
A content/test/gpu/page_sets/data/maps_004.wpr.updated.sha1 View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 23 (13 generated)
Ken Russell (switch to Gerrit)
Thanks for putting this together. It looks good overall. Note, we aren't using the maps_002 ...
4 years, 3 months ago (2016-09-15 17:52:19 UTC) #7
Ken Russell (switch to Gerrit)
+ynovikov as FYI
4 years, 3 months ago (2016-09-15 17:52:52 UTC) #8
nednguyen
On 2016/09/15 17:52:52, Ken Russell wrote: > +ynovikov as FYI +Ken: how do I enable ...
4 years, 3 months ago (2016-09-15 18:02:42 UTC) #9
ynovikov
On 2016/09/15 18:02:42, nednguyen wrote: > On 2016/09/15 17:52:52, Ken Russell wrote: > > +ynovikov ...
4 years, 3 months ago (2016-09-15 18:25:55 UTC) #10
nednguyen
On 2016/09/15 18:25:55, ynovikov wrote: > On 2016/09/15 18:02:42, nednguyen wrote: > > On 2016/09/15 ...
4 years, 3 months ago (2016-09-15 18:33:06 UTC) #11
Ken Russell (switch to Gerrit)
Thanks Yuly for testing. Ned, I don't think the Android One runs WebGL properly, or ...
4 years, 3 months ago (2016-09-15 23:10:19 UTC) #14
nednguyen
https://codereview.chromium.org/2347483004/diff/1/content/test/gpu/gpu_tests/maps.py File content/test/gpu/gpu_tests/maps.py (right): https://codereview.chromium.org/2347483004/diff/1/content/test/gpu/gpu_tests/maps.py#newcode120 content/test/gpu/gpu_tests/maps.py:120: directories in any CL which updates the recording.""" On ...
4 years, 3 months ago (2016-09-15 23:24:35 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2347483004/20001
4 years, 3 months ago (2016-09-15 23:25:12 UTC) #19
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-16 00:35:27 UTC) #21
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 00:37:12 UTC) #23
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c582e5311da945d4e123f499be07f3bba2976750
Cr-Commit-Position: refs/heads/master@{#419056}

Powered by Google App Engine
This is Rietveld 408576698