[DevTools] Remove SidebarTreeElement from SecurityPanel.
This is a step towards removing SidebarTreeElement, and moving
all tree outlines into shadow dom.
BUG=none
Committed: https://crrev.com/93f5f00503677ebb5575cca280e9506cf354824f
Cr-Commit-Position: refs/heads/master@{#419062}
4 years, 3 months ago
(2016-09-15 00:02:31 UTC)
#2
Could you please take a look?
alph
lgtm https://codereview.chromium.org/2347483002/diff/1/third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js File third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js (right): https://codereview.chromium.org/2347483002/diff/1/third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js#newcode394 third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js:394: var originGroup = new TreeElement(WebInspector.UIString(originGroupName), true); drop UIString.
4 years, 3 months ago
(2016-09-15 17:24:16 UTC)
#3
4 years, 3 months ago
(2016-09-16 01:00:01 UTC)
#8
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
commit-bot: I haz the power
Description was changed from ========== [DevTools] Remove SidebarTreeElement from SecurityPanel. This is a step towards ...
4 years, 3 months ago
(2016-09-16 01:02:10 UTC)
#9
Message was sent while issue was closed.
Description was changed from
==========
[DevTools] Remove SidebarTreeElement from SecurityPanel.
This is a step towards removing SidebarTreeElement, and moving
all tree outlines into shadow dom.
BUG=none
==========
to
==========
[DevTools] Remove SidebarTreeElement from SecurityPanel.
This is a step towards removing SidebarTreeElement, and moving
all tree outlines into shadow dom.
BUG=none
Committed: https://crrev.com/93f5f00503677ebb5575cca280e9506cf354824f
Cr-Commit-Position: refs/heads/master@{#419062}
==========
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/93f5f00503677ebb5575cca280e9506cf354824f Cr-Commit-Position: refs/heads/master@{#419062}
4 years, 3 months ago
(2016-09-16 01:02:12 UTC)
#10
Issue 2347483002: [DevTools] Remove SidebarTreeElement from SecurityPanel.
(Closed)
Created 4 years, 3 months ago by dgozman
Modified 4 years, 3 months ago
Reviewers: alph
Base URL:
Comments: 2