Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 2347483002: [DevTools] Remove SidebarTreeElement from SecurityPanel. (Closed)

Created:
4 years, 3 months ago by dgozman
Modified:
4 years, 3 months ago
Reviewers:
alph
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Remove SidebarTreeElement from SecurityPanel. This is a step towards removing SidebarTreeElement, and moving all tree outlines into shadow dom. BUG=none Committed: https://crrev.com/93f5f00503677ebb5575cca280e9506cf354824f Cr-Commit-Position: refs/heads/master@{#419062}

Patch Set 1 #

Total comments: 2

Patch Set 2 : nit #

Messages

Total messages: 10 (4 generated)
dgozman
Could you please take a look?
4 years, 3 months ago (2016-09-15 00:02:31 UTC) #2
alph
lgtm https://codereview.chromium.org/2347483002/diff/1/third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js File third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js (right): https://codereview.chromium.org/2347483002/diff/1/third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js#newcode394 third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js:394: var originGroup = new TreeElement(WebInspector.UIString(originGroupName), true); drop UIString.
4 years, 3 months ago (2016-09-15 17:24:16 UTC) #3
dgozman
Thanks for review! https://codereview.chromium.org/2347483002/diff/1/third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js File third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js (right): https://codereview.chromium.org/2347483002/diff/1/third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js#newcode394 third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js:394: var originGroup = new TreeElement(WebInspector.UIString(originGroupName), true); ...
4 years, 3 months ago (2016-09-15 17:25:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2347483002/20001
4 years, 3 months ago (2016-09-15 22:48:09 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-16 01:00:01 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 01:02:12 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/93f5f00503677ebb5575cca280e9506cf354824f
Cr-Commit-Position: refs/heads/master@{#419062}

Powered by Google App Engine
This is Rietveld 408576698