third_party/WebKit/Source/modules/serviceworkers/ForeignFetchResponse.idl - Issue 2347473005: Make required dictionary members non-nullable again

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/serviceworkers/ForeignFetchResponse.idl

Issue 2347473005: Make required dictionary members non-nullable again (Closed)

Patch Set: rm TouchInit, add tests Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/modules/serviceworkers/ForeignFetchResponse.idl

diff --git a/third_party/WebKit/Source/modules/serviceworkers/ForeignFetchResponse.idl b/third_party/WebKit/Source/modules/serviceworkers/ForeignFetchResponse.idl

index 9db9060525ff1383e3a863e8759f07dee743b5d3..ea6bfbe572ac23593fbe08b41c5f5ef81006fcf7 100644

--- a/third_party/WebKit/Source/modules/serviceworkers/ForeignFetchResponse.idl

+++ b/third_party/WebKit/Source/modules/serviceworkers/ForeignFetchResponse.idl

@@ -5,8 +5,7 @@

// https://w3c.github.io/ServiceWorker/#dictdef-foreignfetchevent-foreignfetchresponse

dictionary ForeignFetchResponse {

- // TODO(foolip): |response| should not be nullable. https://crbug.com/647693

- required Response? response;

+ required Response response;

USVString origin;

sequence<ByteString> headers;

};

« no previous file with comments | « third_party/WebKit/Source/modules/serviceworkers/ForeignFetchEventInit.idl ('k') | no next file » | no next file with comments »