third_party/WebKit/Source/modules/notifications/NotificationEventInit.idl - Issue 2347473005: Make required dictionary members non-nullable again

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/modules/notifications/NotificationEventInit.idl

Issue 2347473005: Make required dictionary members non-nullable again (Closed)

Patch Set: rm TouchInit, add tests Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // https://notifications.spec.whatwg.org/#notificationevent	5 // https://notifications.spec.whatwg.org/#notificationevent

6	6

7 dictionary NotificationEventInit : ExtendableEventInit {	7 dictionary NotificationEventInit : ExtendableEventInit {

8 // TODO(foolip): \|notification\| should not be nullable.	8 required Notification notification;

9 // https://crbug.com/647693

10 required Notification? notification;

11 DOMString action = "";	9 DOMString action = "";

12 };	10 };

OLD	NEW