Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Unified Diff: third_party/sfntly/BUILD.gn

Issue 2347443002: Compile the skia library for windows using gn. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« gn/BUILD.gn ('K') | « gn/BUILDCONFIG.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/sfntly/BUILD.gn
diff --git a/third_party/sfntly/BUILD.gn b/third_party/sfntly/BUILD.gn
index 845c6ed198851393fb272741a49c2285b234a8d1..07a7df900371a16bab4dbc77ba5ab771d0f22c83 100644
--- a/third_party/sfntly/BUILD.gn
+++ b/third_party/sfntly/BUILD.gn
@@ -70,4 +70,13 @@ third_party("sfntly") {
"../externals/sfntly/cpp/src/sfntly/tools/subsetter/subsetter.cc",
"../externals/sfntly/cpp/src/sfntly/tools/subsetter/table_subsetter_impl.cc",
]
+
+ if (is_win) {
+ defines += [ "WIN32", "NOMINMAX" ]
mtklein 2016/09/14 21:25:14 Probably do not need NOMINMAX again. Better check
herb_g 2016/09/16 19:54:15 Done.
+ #cflags += [
+ # "/wd4267",
+ # "/wd4244",
mtklein 2016/09/14 21:25:14 Can you make the template in third_party/third_par
herb_g 2016/09/16 19:54:15 Done.
+ #]
+ cflags_cc = [ "/EHsc", ]
mtklein 2016/09/14 21:25:14 Let's confirm SFNTLY_NO_EXCEPTION doesn't work eno
herb_g 2016/09/16 19:54:15 Done.
+ }
}
« gn/BUILD.gn ('K') | « gn/BUILDCONFIG.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698