Add short-cut in CFX_{Byte,Wide}String::Operator<()

Add short-cut in CFX_{Byte,Wide}String::Operator<()

Strings are never less than themselves, and this will occur given
the shared CoW nature of these strings.

Committed: https://pdfium.googlesource.com/pdfium/+/8f53f54a9ccada2ea8651f2786f1bbee323f09b7

[Tom Sepez, 2016-09-15 17:18:27]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-15 17:18:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Sepez, 2016-09-15 17:19:16]

tsepez@chromium.org changed reviewers:
+ dsinclair@chromium.org

[Tom Sepez, 2016-09-15 17:19:17]

Dan, for review.  Similar to previous CL, and it occurs to me we can do the same
thing for str1 < str2.

[dsinclair, 2016-09-15 17:21:34]

https://codereview.chromium.org/2347433004/diff/1/core/fxcrt/fx_basic_wstring...
File core/fxcrt/fx_basic_wstring.cpp (right):

https://codereview.chromium.org/2347433004/diff/1/core/fxcrt/fx_basic_wstring...
core/fxcrt/fx_basic_wstring.cpp:199: return true;
false?

Should we create a couple simple unit tests?

[Tom Sepez, 2016-09-15 17:25:29]

https://codereview.chromium.org/2347433004/diff/1/core/fxcrt/fx_basic_wstring...
File core/fxcrt/fx_basic_wstring.cpp (right):

https://codereview.chromium.org/2347433004/diff/1/core/fxcrt/fx_basic_wstring...
core/fxcrt/fx_basic_wstring.cpp:199: return true;
On 2016/09/15 17:21:34, dsinclair wrote:
> false?
> 
> Should we create a couple simple unit tests?

I am a moron.  Fixed.

[Tom Sepez, 2016-09-15 17:25:35]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-15 17:25:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dsinclair, 2016-09-15 17:26:05]

lgtm

[Tom Sepez, 2016-09-15 17:43:20]

The CQ bit was unchecked by tsepez@chromium.org

[Tom Sepez, 2016-09-15 17:43:23]

The CQ bit was checked by tsepez@chromium.org

[commit-bot: I haz the power, 2016-09-15 17:43:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 18:55:05]

Description was changed from

==========
Add short-cut in CFX_{Byte,Wide}String::Operator<()

Strings are never less than themselves, and this will occur given
the shared CoW nature of these strings.
==========

to

==========
Add short-cut in CFX_{Byte,Wide}String::Operator<()

Strings are never less than themselves, and this will occur given
the shared CoW nature of these strings.

Committed:
https://pdfium.googlesource.com/pdfium/+/8f53f54a9ccada2ea8651f2786f1bbee323f...
==========

[commit-bot: I haz the power, 2016-09-15 18:55:06]

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/8f53f54a9ccada2ea8651f2786f1bbee323f...