Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2347433003: Cleanup QuicHttpStream to be a bit more consistent with net coding conventions. (Closed)

Created:
4 years, 3 months ago by Ryan Hamilton
Modified:
4 years, 3 months ago
Reviewers:
Buck
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup QuicHttpStream to be a bit more consistent with net coding conventions. Committed: https://crrev.com/a08ce1025855fa8a4518ddbc4229ea9515b794b3 Cr-Commit-Position: refs/heads/master@{#418728}

Patch Set 1 #

Patch Set 2 : More #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -79 lines) Patch
M net/quic/chromium/quic_http_stream.h View 1 3 chunks +7 lines, -3 lines 0 comments Download
M net/quic/chromium/quic_http_stream.cc View 1 6 chunks +81 lines, -76 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Ryan Hamilton
4 years, 3 months ago (2016-09-14 23:03:14 UTC) #2
Buck
lgtm Nice cleanup!
4 years, 3 months ago (2016-09-14 23:35:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2347433003/20001
4 years, 3 months ago (2016-09-14 23:42:58 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-15 00:40:06 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 00:42:40 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a08ce1025855fa8a4518ddbc4229ea9515b794b3
Cr-Commit-Position: refs/heads/master@{#418728}

Powered by Google App Engine
This is Rietveld 408576698