Issue 234743003: Inline TypeImpl::NowContains().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 234743003: Inline TypeImpl::NowContains(). (Closed)

Created:
6 years, 8 months ago by Benedikt Meurer

Modified:
6 years, 8 months ago

Reviewers:
rossberg

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Inline TypeImpl::NowContains(). R=rossberg@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20677

Patch Set 2 : Make Andreas happy. #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -14 lines)			Patch
M	src/types.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/types.cc	View		1 chunk	+0 lines, -13 lines	0 comments	Download
M	src/types-inl.h	View	1	1 chunk	+14 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

rossberg

https://codereview.chromium.org/234743003/diff/1/src/types.h File src/types.h (right): https://codereview.chromium.org/234743003/diff/1/src/types.h#newcode274 src/types.h:274: bool NowContains(i::Object* val) { Can we move that to ...

6 years, 8 months ago (2014-04-11 09:19:37 UTC) #2

Benedikt Meurer

6 years, 8 months ago (2014-04-11 09:23:29 UTC) #3

Benedikt Meurer

6 years, 8 months ago (2014-04-11 09:24:57 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r20677 (presubmit successful).

Expand Messages | Collapse Messages

Issue 234743003: Inline TypeImpl::NowContains(). (Closed)

Description

Patch Set 1 #

Patch Set 2 : Make Andreas happy. #

Messages