Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 2347423003: Add support for package spec to testing HttpServer. (Closed)

Created:
4 years, 3 months ago by Bill Hesse
Modified:
4 years, 3 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add support for package spec to testing HttpServer. BUG=https://github.com/dart-lang/sdk/issues/27065 R=terry@google.com Committed: https://github.com/dart-lang/sdk/commit/88a64b77bf04159061ae3d9f7f8eafac8c3c83c6

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix errors #

Patch Set 3 : Remove fixed comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -102 lines) Patch
D tools/.packages View 1 chunk +0 lines, -9 lines 0 comments Download
M tools/testing/dart/http_server.dart View 1 2 12 chunks +92 lines, -91 lines 0 comments Download
M tools/testing/dart/test_configurations.dart View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Bill Hesse
4 years, 3 months ago (2016-09-19 14:22:41 UTC) #2
Bill Hesse
https://codereview.chromium.org/2347423003/diff/1/tools/.packages File tools/.packages (left): https://codereview.chromium.org/2347423003/diff/1/tools/.packages#oldcode2 tools/.packages:2: # as a pub package, we generated this file ...
4 years, 3 months ago (2016-09-19 15:14:37 UTC) #4
Bill Hesse
4 years, 3 months ago (2016-09-19 15:54:30 UTC) #6
terry
LGTM - will this CL fix the package-root failures in Dartium?
4 years, 3 months ago (2016-09-19 16:33:08 UTC) #7
Bill Hesse
On 2016/09/19 16:33:08, terry wrote: > LGTM - will this CL fix the package-root failures ...
4 years, 3 months ago (2016-09-19 16:33:44 UTC) #8
Bill Hesse
4 years, 3 months ago (2016-09-19 16:43:23 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
88a64b77bf04159061ae3d9f7f8eafac8c3c83c6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698