Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 2347423002: Remove release asserts. (Closed)

Created:
4 years, 3 months ago by cblume
Modified:
4 years, 3 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove release asserts. A handful of changes were added to investigate a bug occurring rarely. The bug has been found and those changes can be reverted. BUG=643845 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2347423002 Committed: https://skia.googlesource.com/skia/+/12f752723b31bb015ded118bfa466c2f1e9b2905

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M src/image/SkImage_Gpu.cpp View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
cblume
PTAL
4 years, 3 months ago (2016-09-19 02:22:31 UTC) #7
bsalomon
lgtm
4 years, 3 months ago (2016-09-19 13:16:24 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2347423002/1
4 years, 3 months ago (2016-09-19 13:16:36 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-19 13:18:05 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/12f752723b31bb015ded118bfa466c2f1e9b2905

Powered by Google App Engine
This is Rietveld 408576698