DevTools: "Jump between editing locations" experiment

Source/devtools/front_end/ScriptsPanel.js

 /*
  * Copyright (C) 2008 Apple Inc. All Rights Reserved.
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 443 matching lines @@
 
         if (this._currentUISourceCode.project().type() === WebInspector.projectTypes.Snippets)
             this._runSnippetButton.element.removeStyleClass("hidden");
         else
             this._runSnippetButton.element.addStyleClass("hidden");
 
         return sourceFrame;
     },
 
     /**
+     * @param {WebInspector.TextEditorPositionHandle} from
+     * @param {WebInspector.TextEditorPositionHandle} to
+     */
+    _onJumpToPosition: function(uiSourceCode, from, to)
+    {
+        if (this._searchQuery)

[vsevik, 2013/09/04 09:46:22]

Please extract all jump specific logic to a separate
ScriptsPanelJumpHistorySupport object, so that ScriptsPanel could only delegate
some events to it.

[lushnikov, 2014/01/02 14:06:09]

Done.

+            return;
+        var fromEntry = from ? new WebInspector.ScriptsPanelJumpHistoryEntry(this, uiSourceCode, from) : null;
+        var toEntry = to ? new WebInspector.ScriptsPanelJumpHistoryEntry(this, uiSourceCode, to) : null;
+        WebInspector.jumpHistoryManager.jumpToPosition(fromEntry, toEntry);
+    },
+
+    /**
      * @param {WebInspector.UISourceCode} uiSourceCode
      * @return {WebInspector.SourceFrame}
      */
     _createSourceFrame: function(uiSourceCode)
     {
         var sourceFrame;
         switch (uiSourceCode.contentType()) {
         case WebInspector.resourceTypes.Script:
             sourceFrame = new WebInspector.JavaScriptSourceFrame(this, uiSourceCode);
             break;
         case WebInspector.resourceTypes.Document:
             sourceFrame = new WebInspector.JavaScriptSourceFrame(this, uiSourceCode);
             break;
         case WebInspector.resourceTypes.Stylesheet:
         default:
             sourceFrame = new WebInspector.UISourceCodeFrame(uiSourceCode);
         break;
         }
         this._sourceFramesByUISourceCode.put(uiSourceCode, sourceFrame);
+        sourceFrame.setJumpToPositionDelegate(this._onJumpToPosition.bind(this, uiSourceCode));
         return sourceFrame;
     },
 
     /**
      * @param {WebInspector.UISourceCode} uiSourceCode
      * @return {WebInspector.SourceFrame}
      */
     _getOrCreateSourceFrame: function(uiSourceCode)
     {
         return this._sourceFramesByUISourceCode.get(uiSourceCode) || this._createSourceFrame(uiSourceCode);
@@ skipping 66 matching lines @@
     },
 
     _editorClosed: function(event)
     {
         this._navigatorController.hideNavigatorOverlay();
         var uiSourceCode = /** @type {WebInspector.UISourceCode} */ (event.data);
 
         if (this._currentUISourceCode === uiSourceCode)
             delete this._currentUISourceCode;
 
+        function historyFilter(projectId, path, entry)
+        {
+            if (!(entry instanceof WebInspector.ScriptsPanelJumpHistoryEntry))
+                return false;
+            return entry._path === path && entry._projectId === projectId;
+        }
+        WebInspector.jumpHistoryManager.filterHistoryEntries(historyFilter.bind(this, uiSourceCode.project().id(), uiSourceCode.path()));
         // ScriptsNavigator does not need to update on EditorClosed.
         this._updateScriptViewStatusBarItems();
         WebInspector.searchController.resetSearch();
     },
 
     _editorSelected: function(event)
     {
         var uiSourceCode = /** @type {WebInspector.UISourceCode} */ (event.data);
         var sourceFrame = this._showFile(uiSourceCode);
         this._navigatorController.hideNavigatorOverlay();
@@ skipping 861 matching lines @@
         } else {
             this._editorFooterElement.addStyleClass("hidden");
             this._editorFooterElement.removeChildren();
             this._editorContentsElement.style.bottom = 0;
         }
         this.doResize();
     },
 
     __proto__: WebInspector.Panel.prototype
 }
+
+/**
+ * @constructor
+ * @implements {WebInspector.JumpHistoryEntry}
+ * @param {WebInspector.ScriptsPanel} scriptsPanel
+ * @param {WebInspector.UISourceCode} uiSourceCode
+ * @param {WebInspector.TextEditorPositionHandle} position
+ */
+WebInspector.ScriptsPanelJumpHistoryEntry = function(scriptsPanel, uiSourceCode, position)
+{
+    this._scriptsPanel = scriptsPanel;
+    this._projectId = uiSourceCode.project().id();
+    this._path = uiSourceCode.path();
+    this._position = position;
+}
+
+WebInspector.ScriptsPanelJumpHistoryEntry.prototype = {
+    /**
+     * @return {boolean}
+     */
+    valid: function()
+    {
+        return !!this._position.resolve();
+    },
+
+    /**
+     * @param {WebInspector.JumpHistoryEntry} entry
+     */
+    merge: function(entry)
+    {
+        if (!(entry instanceof WebInspector.ScriptsPanelJumpHistoryEntry))
+            return;
+        if (entry._projectId === this._projectId && entry._path === this._path)
+            this._position = entry._position;
+    },
+
+    /**
+     * @return {boolean}
+     */
+    reveal: function()
+    {
+        if (!this._scriptsPanel.isShowing())
+            WebInspector.inspectorView.setCurrentPanel(this._scriptsPanel);
+        var position = this._position.resolve();
+        var uiSourceCode = WebInspector.workspace.project(this._projectId).uiSourceCode(this._path);
+        this._scriptsPanel._showSourceLocation(uiSourceCode, position.lineNumber, position.columnNumber);
+        return true;
+    },
+
+    /**
+     * @param {WebInspector.JumpHistoryEntry} entry
+     */
+    equal: function(entry)
+    {
+        if (!(entry instanceof WebInspector.ScriptsPanelJumpHistoryEntry))
+            return false;
+        return entry._projectId === this._projectId && entry._path === this._path && entry._position.equal(this._position);
+    }
+}