X11: Use better visuals for OpenGL

extensions/browser/api/app_window/app_window_apitest.cc

Index: extensions/browser/api/app_window/app_window_apitest.cc
diff --git a/extensions/browser/api/app_window/app_window_apitest.cc b/extensions/browser/api/app_window/app_window_apitest.cc
index 3d68f8626e6c0a2b07cb718e8542875fdd2eeb35..857c40343291343e490595903544b8ea9b300cfe 100644
--- a/extensions/browser/api/app_window/app_window_apitest.cc
+++ b/extensions/browser/api/app_window/app_window_apitest.cc
@@ -24,10 +24,6 @@
 #include "ui/base/win/shell.h"
 #endif
 
-#if defined(USE_X11) && !defined(OS_CHROMEOS)
-#include "ui/gfx/x/x11_switches.h"
-#endif
-
 namespace extensions {
 
 namespace {
@@ -152,13 +148,6 @@ IN_PROC_BROWSER_TEST_F(PlatformAppBrowserTest,
 #endif  // OS_WIN
 #endif  // USE_AURA && (OS_CHROMEOS || !OS_LINUX)
 
-#if defined(USE_X11) && !defined(OS_CHROMEOS)

[Tom (Use chromium acct), 2016/09/22 19:53:29]

I had to remove this because the GL implementation used is
kGLImplementationOSMesaGL, not kGLImplementationDesktopGL :(

[piman, 2016/09/22 21:24:55]

When running with --use-gpu-in-tests (locally), I think you should be getting
kGLImplementationDesktopGL. Most bots don't have a GPU so they're running on
OSMesa, though GPU bots should have GL working.

[Tom (Use chromium acct), 2016/09/23 20:00:37]

Acknowledged.

-  if (base::CommandLine::ForCurrentProcess()->GetSwitchValueASCII(
-          switches::kWindowDepth) == "32") {
-    test_dir = kHasAlphaDir;
-  }
-#endif  // USE_X11 && !OS_CHROMEOS
-
   EXPECT_TRUE(RunPlatformAppTest(test_dir)) << message_;
 }