X11: Use better visuals for OpenGL

ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/widget/desktop_aura/desktop_window_tree_host_x11.h"
 
 #include <X11/extensions/shape.h>
 #include <X11/extensions/XInput2.h>
 #include <X11/Xatom.h>
 #include <X11/Xregion.h>
@@ skipping 1341 matching lines @@
       window_type = atom_cache_.GetAtom("_NET_WM_WINDOW_TYPE_NORMAL");
       break;
   }
   // An in-activatable window should not interact with the system wm.
   if (!activatable_)
     swa.override_redirect = True;
 
   if (swa.override_redirect)
     attribute_mask |= CWOverrideRedirect;
 
-  const bool enable_transparent_visuals =
-      params.type == Widget::InitParams::TYPE_DRAG ||
-      params.type == Widget::InitParams::TYPE_WINDOW;
+  bool enable_transparent_visuals;
+  switch (params.opacity) {
+    case Widget::InitParams::OPAQUE_WINDOW:
+      enable_transparent_visuals = false;
+      break;
+    case Widget::InitParams::TRANSLUCENT_WINDOW:
+      enable_transparent_visuals = true;
+      break;
+    case Widget::InitParams::INFER_OPACITY:
+    default:
+      enable_transparent_visuals = params.type == Widget::InitParams::TYPE_DRAG;
+  }
 
   Visual* visual = CopyFromParent;
   int depth = CopyFromParent;
-  ui::ChooseVisualForWindow(enable_transparent_visuals, &visual, &depth);
-  if (enable_transparent_visuals && depth == 32) {
-    attribute_mask |= CWColormap;
-    swa.colormap =
-        XCreateColormap(xdisplay_, x_root_window_, visual, AllocNone);
+  Colormap colormap = CopyFromParent;
+  ui::XVisualManager::GetInstance()->ChooseVisualForWindow(
+      enable_transparent_visuals, &visual, &depth, &colormap,
+      &use_argb_visual_);
 
-    // x.org will BadMatch if we don't set a border when the depth isn't the
-    // same as the parent depth.
-    attribute_mask |= CWBorderPixel;
-    swa.border_pixel = 0;
+  attribute_mask |= CWColormap;
+  swa.colormap = colormap;
 
-    // A compositing manager is required to support transparency.
-    use_argb_visual_ =
-        XGetSelectionOwner(xdisplay_, atom_cache_.GetAtom("_NET_WM_CM_S0")) !=
-        None;
-  }
+  // x.org will BadMatch if we don't set a border when the depth isn't the
+  // same as the parent depth.
+  attribute_mask |= CWBorderPixel;
+  swa.border_pixel = 0;
 
   bounds_in_pixels_ = ToPixelRect(params.bounds);
   bounds_in_pixels_.set_size(AdjustSize(bounds_in_pixels_.size()));
   xwindow_ = XCreateWindow(xdisplay_, x_root_window_, bounds_in_pixels_.x(),
                            bounds_in_pixels_.y(), bounds_in_pixels_.width(),
                            bounds_in_pixels_.height(),
                            0,  // border width
                            depth, InputOutput, visual, attribute_mask, &swa);
   if (ui::PlatformEventSource::GetInstance())
     ui::PlatformEventSource::GetInstance()->AddPlatformEventDispatcher(this);
@@ skipping 919 matching lines @@
   if (linux_ui) {
     ui::NativeTheme* native_theme = linux_ui->GetNativeTheme(window);
     if (native_theme)
       return native_theme;
   }
 
   return ui::NativeThemeAura::instance();
 }
 
 }  // namespace views