Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(941)

Issue 2347343002: cc_blink: Fix a leak in web layer impl fixed bounds test. (Closed)

Created:
4 years, 3 months ago by vmpstr
Modified:
4 years, 3 months ago
Reviewers:
danakj
CC:
chromium-reviews, cc-bugs_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc_blink: Fix a leak in web layer impl fixed bounds test. This patch cleans up the web layer impl fixed bounds test a bit to use less pointers (some of which were leaked). R=danakj CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/3fc44d83c7ba8fbe14615924441f42028e959854 Cr-Commit-Position: refs/heads/master@{#419575}

Patch Set 1 #

Patch Set 2 : update #

Patch Set 3 : update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -45 lines) Patch
M cc/blink/web_layer_impl.h View 1 2 2 chunks +6 lines, -6 lines 0 comments Download
M cc/blink/web_layer_impl_fixed_bounds.h View 1 2 chunks +4 lines, -5 lines 0 comments Download
M cc/blink/web_layer_impl_fixed_bounds_unittest.cc View 3 chunks +32 lines, -34 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
vmpstr
Please take a look. I don't think the export hurts much?
4 years, 3 months ago (2016-09-16 23:56:14 UTC) #2
danakj
LGTM
4 years, 3 months ago (2016-09-17 00:05:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2347343002/1
4 years, 3 months ago (2016-09-17 00:10:15 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/259316)
4 years, 3 months ago (2016-09-17 01:24:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2347343002/20001
4 years, 3 months ago (2016-09-19 18:34:46 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/259902)
4 years, 3 months ago (2016-09-19 19:33:46 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2347343002/40001
4 years, 3 months ago (2016-09-19 20:22:05 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-19 21:48:55 UTC) #16
commit-bot: I haz the power
4 years, 3 months ago (2016-09-19 21:50:27 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/3fc44d83c7ba8fbe14615924441f42028e959854
Cr-Commit-Position: refs/heads/master@{#419575}

Powered by Google App Engine
This is Rietveld 408576698