Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1125)

Issue 2347333002: [wasm] Fix for cloning module heap size value (Closed)

Created:
4 years, 3 months ago by Mircea Trofin
Modified:
4 years, 2 months ago
Reviewers:
titzer, bradnelson
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Fix for cloning module heap size value The module size is encoded as a HeapNumber, and needs to be explicitly cloned. BUG=chromium:647649 Committed: https://crrev.com/df490c348433186f98bca50670b0b9094bd06ca1 Cr-Commit-Position: refs/heads/master@{#39845}

Patch Set 1 #

Patch Set 2 : test: moved, and flags #

Patch Set 3 : just the test #

Patch Set 4 : the fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -0 lines) Patch
M src/wasm/wasm-module.cc View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download
A test/mjsunit/regress/wasm/regression-647649.js View 1 1 chunk +43 lines, -0 lines 0 comments Download

Messages

Total messages: 25 (17 generated)
Mircea Trofin
4 years, 3 months ago (2016-09-16 23:10:46 UTC) #5
bradnelson
lgtm
4 years, 3 months ago (2016-09-16 23:38:30 UTC) #10
titzer
On 2016/09/16 23:38:30, bradnelson wrote: > lgtm I noticed this as well while working on ...
4 years, 3 months ago (2016-09-18 15:25:24 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2347333002/40001
4 years, 2 months ago (2016-09-28 23:53:43 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/builds/9596) v8_linux64_avx2_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, ...
4 years, 2 months ago (2016-09-29 00:08:51 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2347333002/60001
4 years, 2 months ago (2016-09-29 00:23:10 UTC) #21
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 2 months ago (2016-09-29 00:48:18 UTC) #23
commit-bot: I haz the power
4 years, 2 months ago (2016-09-29 00:48:36 UTC) #25
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/df490c348433186f98bca50670b0b9094bd06ca1
Cr-Commit-Position: refs/heads/master@{#39845}

Powered by Google App Engine
This is Rietveld 408576698