|
|
Created:
4 years, 3 months ago by Mircea Trofin Modified:
4 years, 2 months ago CC:
v8-reviews_googlegroups.com Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[wasm] Fix for cloning module heap size value
The module size is encoded as a HeapNumber, and needs to be
explicitly cloned.
BUG=chromium:647649
Committed: https://crrev.com/df490c348433186f98bca50670b0b9094bd06ca1
Cr-Commit-Position: refs/heads/master@{#39845}
Patch Set 1 #Patch Set 2 : test: moved, and flags #Patch Set 3 : just the test #Patch Set 4 : the fix #
Messages
Total messages: 25 (17 generated)
The CQ bit was checked by mtrofin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== [wasm] Fix for cloning module heap size value The module size is encoded as a HeapNumber, and needs to be explicitly cloned. BUG=chromium:647649 ========== to ========== [wasm] Fix for cloning module heap size value The module size is encoded as a HeapNumber, and needs to be explicitly cloned. BUG=chromium:647649 ==========
mtrofin@chromium.org changed reviewers: + bradnelson@chromium.org, titzer@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...) v8_linux64_gyp_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng_trigg...)
The CQ bit was checked by mtrofin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2016/09/16 23:38:30, bradnelson wrote: > lgtm I noticed this as well while working on the 0xC patch ;-)
The CQ bit was checked by mtrofin@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from bradnelson@chromium.org Link to the patchset: https://codereview.chromium.org/2347333002/#ps40001 (title: "just the test")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...) v8_linux64_avx2_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng_trig...)
The CQ bit was checked by mtrofin@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from bradnelson@chromium.org Link to the patchset: https://codereview.chromium.org/2347333002/#ps60001 (title: "the fix")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [wasm] Fix for cloning module heap size value The module size is encoded as a HeapNumber, and needs to be explicitly cloned. BUG=chromium:647649 ========== to ========== [wasm] Fix for cloning module heap size value The module size is encoded as a HeapNumber, and needs to be explicitly cloned. BUG=chromium:647649 ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== [wasm] Fix for cloning module heap size value The module size is encoded as a HeapNumber, and needs to be explicitly cloned. BUG=chromium:647649 ========== to ========== [wasm] Fix for cloning module heap size value The module size is encoded as a HeapNumber, and needs to be explicitly cloned. BUG=chromium:647649 Committed: https://crrev.com/df490c348433186f98bca50670b0b9094bd06ca1 Cr-Commit-Position: refs/heads/master@{#39845} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/df490c348433186f98bca50670b0b9094bd06ca1 Cr-Commit-Position: refs/heads/master@{#39845} |