Remove duplicated charset definitions

Remove duplicated charset definitions, and move them to fx_font.h

PWL_FontMap does not need its own charset definitions. fx_edit.h does
not need to define DEFAULT_CHARSET. XFA have their own definitions.
They look different in that most are MAC or MSWin charset definitions.
So they are left untouched. public/fpdf_sysfontinfo.h duplicate ones
were left untouched due to being in public folder.

Committed: https://pdfium.googlesource.com/pdfium/+/ea3c3be83dae12ef682c68fc7cf906d790fd9f84

[npm, 2016-09-16 22:20:46]

The CQ bit was checked by npm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-16 22:20:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[npm, 2016-09-16 22:28:52]

Description was changed from

==========
Remove duplicated charset definitions
==========

to

==========
Remove duplicated charset definitions, and move them to fx_font.h

PWL_FontMap does not need its own charset definitions. fx_edit.h does
not need to define DEFAULT_CHARSET. XFA have their own definitions.
They look different in that most are MAC or MSWin charset definitions.
So they are left untouched. public/fpdf_sysfontinfo.h duplicate ones
were left untouched due to being in public folder.
==========

[npm, 2016-09-16 22:28:52]

npm@chromium.org changed reviewers:
+ dsinclair@chromium.org, weili@chromium.org

[npm, 2016-09-16 22:30:37]

PTAL

[commit-bot: I haz the power, 2016-09-16 22:35:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-16 22:35:18]

Dry run: This issue passed the CQ dry run.

[dsinclair, 2016-09-19 13:04:54]

https://codereview.chromium.org/2347313002/diff/1/fpdfsdk/pdfwindow/PWL_Edit.cpp
File fpdfsdk/pdfwindow/PWL_Edit.cpp (right):

https://codereview.chromium.org/2347313002/diff/1/fpdfsdk/pdfwindow/PWL_Edit....
fpdfsdk/pdfwindow/PWL_Edit.cpp:17: #include
"core/fxge/include/cfx_renderdevice.h"
This should have core/fxge/include/fx_font.h so DEFAULT_FONT is defined, yea?

https://codereview.chromium.org/2347313002/diff/1/fpdfsdk/pdfwindow/PWL_EditC...
File fpdfsdk/pdfwindow/PWL_EditCtrl.cpp (right):

https://codereview.chromium.org/2347313002/diff/1/fpdfsdk/pdfwindow/PWL_EditC...
fpdfsdk/pdfwindow/PWL_EditCtrl.cpp:10: #include
"core/fpdfdoc/include/cpvt_word.h"
Include fx_font.h?

https://codereview.chromium.org/2347313002/diff/1/fpdfsdk/pdfwindow/PWL_FontM...
File fpdfsdk/pdfwindow/PWL_FontMap.cpp (right):

https://codereview.chromium.org/2347313002/diff/1/fpdfsdk/pdfwindow/PWL_FontM...
fpdfsdk/pdfwindow/PWL_FontMap.cpp:12: #include
"core/fpdfapi/fpdf_parser/include/cpdf_parser.h"
include fx_font?

https://codereview.chromium.org/2347313002/diff/1/fpdfsdk/pdfwindow/PWL_FontM...
File fpdfsdk/pdfwindow/PWL_FontMap.h (left):

https://codereview.chromium.org/2347313002/diff/1/fpdfsdk/pdfwindow/PWL_FontM...
fpdfsdk/pdfwindow/PWL_FontMap.h:32: #define ANSI_CHARSET 0
Did you check that these numbers all line up with the other file?

[npm, 2016-09-19 14:08:32]

PTAL

https://codereview.chromium.org/2347313002/diff/1/fpdfsdk/pdfwindow/PWL_Edit.cpp
File fpdfsdk/pdfwindow/PWL_Edit.cpp (right):

https://codereview.chromium.org/2347313002/diff/1/fpdfsdk/pdfwindow/PWL_Edit....
fpdfsdk/pdfwindow/PWL_Edit.cpp:17: #include
"core/fxge/include/cfx_renderdevice.h"
On 2016/09/19 13:04:53, dsinclair wrote:
> This should have core/fxge/include/fx_font.h so DEFAULT_FONT is defined, yea?

Done.

https://codereview.chromium.org/2347313002/diff/1/fpdfsdk/pdfwindow/PWL_EditC...
File fpdfsdk/pdfwindow/PWL_EditCtrl.cpp (right):

https://codereview.chromium.org/2347313002/diff/1/fpdfsdk/pdfwindow/PWL_EditC...
fpdfsdk/pdfwindow/PWL_EditCtrl.cpp:10: #include
"core/fpdfdoc/include/cpvt_word.h"
On 2016/09/19 13:04:53, dsinclair wrote:
> Include fx_font.h?

Done.

https://codereview.chromium.org/2347313002/diff/1/fpdfsdk/pdfwindow/PWL_FontM...
File fpdfsdk/pdfwindow/PWL_FontMap.cpp (right):

https://codereview.chromium.org/2347313002/diff/1/fpdfsdk/pdfwindow/PWL_FontM...
fpdfsdk/pdfwindow/PWL_FontMap.cpp:12: #include
"core/fpdfapi/fpdf_parser/include/cpdf_parser.h"
On 2016/09/19 13:04:53, dsinclair wrote:
> include fx_font?

Its included in fpdfsdk/pdfwindow/PWL_FontMap.h. Do we still need to have it
here?

https://codereview.chromium.org/2347313002/diff/1/fpdfsdk/pdfwindow/PWL_FontM...
File fpdfsdk/pdfwindow/PWL_FontMap.h (left):

https://codereview.chromium.org/2347313002/diff/1/fpdfsdk/pdfwindow/PWL_FontM...
fpdfsdk/pdfwindow/PWL_FontMap.h:32: #define ANSI_CHARSET 0
On 2016/09/19 13:04:53, dsinclair wrote:
> Did you check that these numbers all line up with the other file?

Yes

[dsinclair, 2016-09-19 14:11:11]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-09-19 14:11:12]

lgtm

[commit-bot: I haz the power, 2016-09-19 14:11:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-19 14:24:35]

Description was changed from

==========
Remove duplicated charset definitions, and move them to fx_font.h

PWL_FontMap does not need its own charset definitions. fx_edit.h does
not need to define DEFAULT_CHARSET. XFA have their own definitions.
They look different in that most are MAC or MSWin charset definitions.
So they are left untouched. public/fpdf_sysfontinfo.h duplicate ones
were left untouched due to being in public folder.
==========

to

==========
Remove duplicated charset definitions, and move them to fx_font.h

PWL_FontMap does not need its own charset definitions. fx_edit.h does
not need to define DEFAULT_CHARSET. XFA have their own definitions.
They look different in that most are MAC or MSWin charset definitions.
So they are left untouched. public/fpdf_sysfontinfo.h duplicate ones
were left untouched due to being in public folder.

Committed:
https://pdfium.googlesource.com/pdfium/+/ea3c3be83dae12ef682c68fc7cf906d790fd...
==========

[commit-bot: I haz the power, 2016-09-19 14:24:36]

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/ea3c3be83dae12ef682c68fc7cf906d790fd...