Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Issue 2347303002: Update status after package root removal (Closed)

Created:
4 years, 3 months ago by Bill Hesse
Modified:
4 years, 3 months ago
CC:
reviews_dartlang.org, Harry Terkelsen
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Update status after package root removal BUG=https://github.com/dart-lang/sdk/issues/27378 Committed: https://github.com/dart-lang/sdk/commit/82c24568d461fa76f6a3a3df97c883b4903c9ef4 Reopened to add new commit, fixing CL Committed: https://github.com/dart-lang/sdk/commit/338e7e25f3f80675e39bb2b9a443bae89bb54c39

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix error in this CL #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M tests/compiler/dart2js/dart2js.status View 1 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Bill Hesse
TBR=sigmund@google.com
4 years, 3 months ago (2016-09-16 21:45:23 UTC) #2
Bill Hesse
Committed patchset #1 (id:1) manually as 82c24568d461fa76f6a3a3df97c883b4903c9ef4 (presubmit successful).
4 years, 3 months ago (2016-09-16 21:46:19 UTC) #4
Siggi Cherem (dart-lang)
https://codereview.chromium.org/2347303002/diff/1/tests/compiler/dart2js/dart2js.status File tests/compiler/dart2js/dart2js.status (right): https://codereview.chromium.org/2347303002/diff/1/tests/compiler/dart2js/dart2js.status#newcode22 tests/compiler/dart2js/dart2js.status:22: library_resolution_test: Fail # Issue 27378 Harry submitted a fix ...
4 years, 3 months ago (2016-09-16 21:54:55 UTC) #5
Bill Hesse
On 2016/09/16 21:54:55, Siggi Cherem (dart-lang) wrote: > https://codereview.chromium.org/2347303002/diff/1/tests/compiler/dart2js/dart2js.status > File tests/compiler/dart2js/dart2js.status (right): > > ...
4 years, 3 months ago (2016-09-16 22:00:20 UTC) #6
Bill Hesse
On 2016/09/16 22:00:20, Bill Hesse wrote: > On 2016/09/16 21:54:55, Siggi Cherem (dart-lang) wrote: > ...
4 years, 3 months ago (2016-09-16 22:04:29 UTC) #8
Bill Hesse
Committed patchset #2 (id:20001) manually as 338e7e25f3f80675e39bb2b9a443bae89bb54c39 (presubmit successful).
4 years, 3 months ago (2016-09-16 22:22:29 UTC) #10
Siggi Cherem (dart-lang)
4 years, 3 months ago (2016-09-16 22:26:27 UTC) #11
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698