Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Unified Diff: components/arc/storage_manager/arc_storage_manager.cc

Issue 2347293002: arc: Add InstanceHelper::GetInstanceForMethod() (Closed)
Patch Set: No more DCHECK Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/arc/storage_manager/arc_storage_manager.cc
diff --git a/components/arc/storage_manager/arc_storage_manager.cc b/components/arc/storage_manager/arc_storage_manager.cc
index b284d1af92b77edf6af35ef024864c6cb26a23af..f8cae30155e9faa45e2fb443bdc72acd4c4abc04 100644
--- a/components/arc/storage_manager/arc_storage_manager.cc
+++ b/components/arc/storage_manager/arc_storage_manager.cc
@@ -40,49 +40,35 @@ ArcStorageManager* ArcStorageManager::Get() {
}
bool ArcStorageManager::OpenPrivateVolumeSettings() {
- auto* storage_manager_instance = GetStorageManagerInstance();
- if (!storage_manager_instance) {
+ auto* storage_manager_instance =
+ arc_bridge_service()->storage_manager()->GetInstanceForMethod(
+ "OpenPrivateVolumeSettings", kMinInstanceVersion);
+ if (!storage_manager_instance)
return false;
- }
storage_manager_instance->OpenPrivateVolumeSettings();
return true;
}
bool ArcStorageManager::GetApplicationsSize(
const GetApplicationsSizeCallback& callback) {
- auto* storage_manager_instance = GetStorageManagerInstance();
- if (!storage_manager_instance) {
+ auto* storage_manager_instance =
+ arc_bridge_service()->storage_manager()->GetInstanceForMethod(
+ "GetApplicationsSize", kMinInstanceVersion);
+ if (!storage_manager_instance)
return false;
- }
storage_manager_instance->GetApplicationsSize(callback);
return true;
}
bool ArcStorageManager::DeleteApplicationsCache(
const base::Callback<void()>& callback) {
- auto* storage_manager_instance = GetStorageManagerInstance();
- if (!storage_manager_instance) {
+ auto* storage_manager_instance =
+ arc_bridge_service()->storage_manager()->GetInstanceForMethod(
+ "DeleteApplicationsCache", kMinInstanceVersion);
+ if (!storage_manager_instance)
return false;
- }
storage_manager_instance->DeleteApplicationsCache(callback);
return true;
}
-mojom::StorageManagerInstance* ArcStorageManager::GetStorageManagerInstance() {
- auto* bridge_service = arc_bridge_service();
- auto* storage_manager_instance =
- bridge_service->storage_manager()->instance();
- if (!storage_manager_instance) {
- DLOG(WARNING) << "ARC storage manager instance is not ready.";
- return nullptr;
- }
- auto storage_manager_version = bridge_service->storage_manager()->version();
- if (storage_manager_version < kMinInstanceVersion) {
- DLOG(ERROR) << "ARC storage manager instance (version "
- << storage_manager_version << ") is too old.";
- return nullptr;
- }
- return storage_manager_instance;
-}
-
} // namespace arc
« no previous file with comments | « components/arc/storage_manager/arc_storage_manager.h ('k') | ui/arc/notification/arc_notification_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698