arc: Add InstanceHelper::GetInstanceForMethod()

components/arc/instance_holder.h

Index: components/arc/instance_holder.h
diff --git a/components/arc/instance_holder.h b/components/arc/instance_holder.h
index 4fb5b37023eac07e6303f0c9928c0e8752c8f547..b1c3b950aa07d1cb7a086842f70ca846b333a7c8 100644
--- a/components/arc/instance_holder.h
+++ b/components/arc/instance_holder.h
@@ -42,6 +42,32 @@ class InstanceHolder {
   T* instance() const { return instance_; }
   uint32_t version() const { return version_; }
 
+  // Gets the Mojo interface that's intended to call for
+  // |method_name_for_logging|, but only if its reported version is at least
+  // |min_version|. Returns nullptr if the instance is either not ready or does
+  // not have the requested version, and logs appropriately.
+  T* GetInstanceForMethod(const char* method_name_for_logging,
+                          uint32_t min_version) {
+    DCHECK_LT(0u, min_version) << T::Name_ << "::" << method_name_for_logging;

[Yusuke Sato, 2016/09/17 04:28:05]

nit: you can't have this check anymore since line 68 passes 0u in.

[Luis Héctor Chávez, 2016/09/19 15:33:11]

Done.

+    if (!instance_) {
+      VLOG(1) << "Instance for " << T::Name_ << "::" << method_name_for_logging
+              << " not available.";
+      return nullptr;
+    }
+    if (version_ < min_version) {
+      VLOG(1) << "Instance for " << T::Name_ << "::" << method_name_for_logging
+              << " version mismatch. Expected " << min_version << " got "
+              << version_;
+      return nullptr;
+    }
+    return instance_;
+  }
+
+  // Same as the above, but for the version zero.
+  T* GetInstanceForMethod(const char* method_name_for_logging) {
+    return GetInstanceForMethod(method_name_for_logging, 0u);
+  }
+
   // Adds or removes observers. This can only be called on the thread that this
   // class was created on. RemoveObserver does nothing if |observer| is not in
   // the list.