[Material][Mac] Adjust User Account Button

[Material][Mac] Adjust User Account Button

- Set the title's kern value to 0.25
- Removed the shadows

BUG=646063, 646066
Committed: https://crrev.com/5207594d819ad2d27561b2c4c77841a47da12eae
Cr-Commit-Position: refs/heads/master@{#419850}

[spqchan, 2016-09-17 00:24:41]

spqchan@chromium.org changed reviewers:
+ shrike@chromium.org

[spqchan, 2016-09-17 00:24:41]

PTAL

[shrike, 2016-09-19 22:53:31]

lgtm.

I realize that when mousing over the button the hover color immediately appears
instead of fading in. MD wants fade in. Currently the toolbar buttons don't do
it, but the bookmark buttons do. I will file a new bug for fade in of toolbar
buttons and the user account button. I think it's OK to ship it without fade in
because the toolbar is that way, but we should fix them both after that.

[spqchan, 2016-09-20 00:22:39]

On 2016/09/19 22:53:31, shrike wrote:
> lgtm.
> 
> I realize that when mousing over the button the hover color immediately
appears
> instead of fading in. MD wants fade in. Currently the toolbar buttons don't do
> it, but the bookmark buttons do. I will file a new bug for fade in of toolbar
> buttons and the user account button. I think it's OK to ship it without fade
in
> because the toolbar is that way, but we should fix them both after that.

Sounds good. Can you give me the specs for the fade in (length of time, etc)?
Thanks!

[spqchan, 2016-09-20 00:23:03]

spqchan@chromium.org changed reviewers:
+ avi@chromium.org

[spqchan, 2016-09-20 00:23:04]

+avi for owner

[Avi (use Gerrit), 2016-09-20 00:35:43]

https://codereview.chromium.org/2347283003/diff/1/chrome/browser/ui/cocoa/pro...
File chrome/browser/ui/cocoa/profiles/avatar_button_controller.mm (right):

https://codereview.chromium.org/2347283003/diff/1/chrome/browser/ui/cocoa/pro...
chrome/browser/ui/cocoa/profiles/avatar_button_controller.mm:280: }
This shadow code from lines 262–280 are only used in the non-MD code path now.
Bring them into your new else block.

[spqchan, 2016-09-20 20:16:28]

PTAL

https://codereview.chromium.org/2347283003/diff/1/chrome/browser/ui/cocoa/pro...
File chrome/browser/ui/cocoa/profiles/avatar_button_controller.mm (right):

https://codereview.chromium.org/2347283003/diff/1/chrome/browser/ui/cocoa/pro...
chrome/browser/ui/cocoa/profiles/avatar_button_controller.mm:280: }
On 2016/09/20 00:35:43, Avi wrote:
> This shadow code from lines 262–280 are only used in the non-MD code path now.
> Bring them into your new else block.

Done.

[Avi (use Gerrit), 2016-09-20 20:28:06]

lgtm; thanks

[spqchan, 2016-09-20 20:29:18]

The CQ bit was checked by spqchan@chromium.org

[spqchan, 2016-09-20 20:29:18]

The patchset sent to the CQ was uploaded after l-g-t-m from shrike@chromium.org
Link to the patchset: https://codereview.chromium.org/2347283003/#ps20001
(title: "Fix for avi")

[commit-bot: I haz the power, 2016-09-20 20:29:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[shrike, 2016-09-20 20:41:03]

On 2016/09/20 00:22:39, spqchan wrote:
> Sounds good. Can you give me the specs for the fade in (length of time, etc)?
> Thanks!

I never got any specs. I think the GradientButtonCell class supports fade in and
out, which is what the BookmarkButton uses - you should be able to get timing
from there, if you need it. I think toolbar buttons are also based on
GradientButtonCell. When I did the toolbar work I didn't know that the buttons
needed to fade in and out (it wasn't in the spec).

[spqchan, 2016-09-20 20:42:42]

On 2016/09/20 20:41:03, shrike wrote:
> On 2016/09/20 00:22:39, spqchan wrote:
> > Sounds good. Can you give me the specs for the fade in (length of time,
etc)?
> > Thanks!
> 
> I never got any specs. I think the GradientButtonCell class supports fade in
and
> out, which is what the BookmarkButton uses - you should be able to get timing
> from there, if you need it. I think toolbar buttons are also based on
> GradientButtonCell. When I did the toolbar work I didn't know that the buttons
> needed to fade in and out (it wasn't in the spec).

I see, thanks for the clarifications. Can you create the bug and assign it to
me?

[commit-bot: I haz the power, 2016-09-20 20:49:36]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-20 20:51:07]

Description was changed from

==========
[Material][Mac] Adjust User Account Button

- Set the title's kern value to 0.25
- Removed the shadows

BUG=646063, 646066
==========

to

==========
[Material][Mac] Adjust User Account Button

- Set the title's kern value to 0.25
- Removed the shadows

BUG=646063, 646066

Committed: https://crrev.com/5207594d819ad2d27561b2c4c77841a47da12eae
Cr-Commit-Position: refs/heads/master@{#419850}
==========

[commit-bot: I haz the power, 2016-09-20 20:51:08]

Patchset 2 (id:??) landed as
https://crrev.com/5207594d819ad2d27561b2c4c77841a47da12eae
Cr-Commit-Position: refs/heads/master@{#419850}