Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 2347283002: [layoutng] Add out-of-flow objects to the positioned objects map (Closed)

Created:
4 years, 3 months ago by cbiesinger
Modified:
4 years, 3 months ago
CC:
chromium-reviews, cbiesinger, ojan+watch_chromium.org, szager+layoutwatch_chromium.org, glebl+reviews_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[layoutng] Add out-of-flow objects to the positioned objects map This fixes the main remaining assertion in legacy/ng interop. BUG=635619 R=eae@chromium.org,ikilpatrick@chromium.org,glebl@chromium.org Committed: https://crrev.com/778b1cffa40fa6956ea4aa30623fca8b10a35309 Cr-Commit-Position: refs/heads/master@{#419311}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M third_party/WebKit/Source/core/layout/ng/ng_box.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
cbiesinger
4 years, 3 months ago (2016-09-16 21:24:35 UTC) #1
Gleb Lanbin
lgtm
4 years, 3 months ago (2016-09-16 21:27:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2347283002/1
4 years, 3 months ago (2016-09-16 21:28:36 UTC) #7
cbiesinger
4 years, 3 months ago (2016-09-16 21:34:33 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-16 22:43:43 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/778b1cffa40fa6956ea4aa30623fca8b10a35309 Cr-Commit-Position: refs/heads/master@{#419311}
4 years, 3 months ago (2016-09-16 22:45:48 UTC) #12
eae
4 years, 3 months ago (2016-09-17 08:30:57 UTC) #13
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698