Remove stl_util's STLDeleteContainerPairSecondPointers from storage/.

Remove stl_util's STLDeleteContainerPairSecondPointers from storage/.

BUG=555865
Committed: https://crrev.com/9d3820d506e7a485595da95b32f6b48e27c5aed8
Cr-Commit-Position: refs/heads/master@{#419280}

[Avi (use Gerrit), 2016-09-16 18:46:04]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-16 18:46:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Avi (use Gerrit), 2016-09-16 19:32:22]

avi@chromium.org changed reviewers:
+ danakj@chromium.org

[commit-bot: I haz the power, 2016-09-16 19:44:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-16 19:44:37]

Dry run: This issue passed the CQ dry run.

[danakj, 2016-09-16 19:49:15]

LGTM

https://codereview.chromium.org/2347253002/diff/1/storage/browser/fileapi/ext...
File storage/browser/fileapi/external_mount_points.cc (right):

https://codereview.chromium.org/2347253002/diff/1/storage/browser/fileapi/ext...
storage/browser/fileapi/external_mount_points.cc:206: for (auto iter =
instance_map_.begin(); iter != instance_map_.end(); ++iter) {
can this be a for (const auto& pair : instance_map_)?

https://codereview.chromium.org/2347253002/diff/1/storage/browser/fileapi/ext...
storage/browser/fileapi/external_mount_points.cc:250:
instance_map_copy.swap(instance_map_);
Can you leave a comment saying we're moving these to a local var inside the lock
to free them all outside the lock?

https://codereview.chromium.org/2347253002/diff/1/storage/browser/fileapi/ext...
storage/browser/fileapi/external_mount_points.cc:255:
ExternalMountPoints::ExternalMountPoints() {}
= default while you're here?

https://codereview.chromium.org/2347253002/diff/1/storage/browser/fileapi/ext...
storage/browser/fileapi/external_mount_points.cc:257:
ExternalMountPoints::~ExternalMountPoints() {}
= default?

https://codereview.chromium.org/2347253002/diff/1/storage/browser/fileapi/iso...
File storage/browser/fileapi/isolated_context.cc (right):

https://codereview.chromium.org/2347253002/diff/1/storage/browser/fileapi/iso...
storage/browser/fileapi/isolated_context.cc:416:
IsolatedContext::IsolatedContext() {
= default?

https://codereview.chromium.org/2347253002/diff/1/storage/browser/fileapi/iso...
storage/browser/fileapi/isolated_context.cc:419:
IsolatedContext::~IsolatedContext() {
= default?

[Avi (use Gerrit), 2016-09-16 20:08:51]

https://codereview.chromium.org/2347253002/diff/1/storage/browser/fileapi/ext...
File storage/browser/fileapi/external_mount_points.cc (right):

https://codereview.chromium.org/2347253002/diff/1/storage/browser/fileapi/ext...
storage/browser/fileapi/external_mount_points.cc:206: for (auto iter =
instance_map_.begin(); iter != instance_map_.end(); ++iter) {
On 2016/09/16 19:49:14, danakj wrote:
> can this be a for (const auto& pair : instance_map_)?

Done.

https://codereview.chromium.org/2347253002/diff/1/storage/browser/fileapi/ext...
storage/browser/fileapi/external_mount_points.cc:250:
instance_map_copy.swap(instance_map_);
On 2016/09/16 19:49:14, danakj wrote:
> Can you leave a comment saying we're moving these to a local var inside the
lock
> to free them all outside the lock?

Done.

https://codereview.chromium.org/2347253002/diff/1/storage/browser/fileapi/ext...
storage/browser/fileapi/external_mount_points.cc:255:
ExternalMountPoints::ExternalMountPoints() {}
On 2016/09/16 19:49:14, danakj wrote:
> = default while you're here?

Done.

https://codereview.chromium.org/2347253002/diff/1/storage/browser/fileapi/ext...
storage/browser/fileapi/external_mount_points.cc:257:
ExternalMountPoints::~ExternalMountPoints() {}
On 2016/09/16 19:49:14, danakj wrote:
> = default?

Done.

https://codereview.chromium.org/2347253002/diff/1/storage/browser/fileapi/iso...
File storage/browser/fileapi/isolated_context.cc (right):

https://codereview.chromium.org/2347253002/diff/1/storage/browser/fileapi/iso...
storage/browser/fileapi/isolated_context.cc:416:
IsolatedContext::IsolatedContext() {
On 2016/09/16 19:49:14, danakj wrote:
> = default?

Done.

https://codereview.chromium.org/2347253002/diff/1/storage/browser/fileapi/iso...
storage/browser/fileapi/isolated_context.cc:419:
IsolatedContext::~IsolatedContext() {
On 2016/09/16 19:49:14, danakj wrote:
> = default?

Done.

[Avi (use Gerrit), 2016-09-16 20:09:41]

The CQ bit was checked by avi@chromium.org

[Avi (use Gerrit), 2016-09-16 20:09:42]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org
Link to the patchset: https://codereview.chromium.org/2347253002/#ps20001
(title: "danakj")

[commit-bot: I haz the power, 2016-09-16 20:10:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-16 21:03:25]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-16 21:05:00]

Description was changed from

==========
Remove stl_util's STLDeleteContainerPairSecondPointers from storage/.

BUG=555865
==========

to

==========
Remove stl_util's STLDeleteContainerPairSecondPointers from storage/.

BUG=555865

Committed: https://crrev.com/9d3820d506e7a485595da95b32f6b48e27c5aed8
Cr-Commit-Position: refs/heads/master@{#419280}
==========

[commit-bot: I haz the power, 2016-09-16 21:05:01]

Patchset 2 (id:??) landed as
https://crrev.com/9d3820d506e7a485595da95b32f6b48e27c5aed8
Cr-Commit-Position: refs/heads/master@{#419280}