Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1171)

Unified Diff: base/BUILD.gn

Issue 2347233002: Add src_files to src_jar GN template (Closed)
Patch Set: Small fixes Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/cronet/android/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/BUILD.gn
diff --git a/base/BUILD.gn b/base/BUILD.gn
index a26be55dd92487a88efd937f6e8ab16c6e8ebbc8..80945ee3c036cba92fba643aec69b933555870ad 100644
--- a/base/BUILD.gn
+++ b/base/BUILD.gn
@@ -2253,6 +2253,7 @@ if (is_android) {
srcjar_deps = [
":base_android_java_enums_srcjar",
":base_build_config_gen",
+ ":base_java_srcjar",
agrieve 2016/09/20 00:09:41 Putting these files into a srcjar will make them u
kapishnikov 2016/09/20 14:59:31 That is a very good point. Thanks for the idea of
":base_native_libraries_gen",
]
@@ -2262,7 +2263,18 @@ if (is_android) {
"//third_party/jsr-305:jsr_305_javalib",
]
- java_files = [
+ # New versions of BuildConfig.java and NativeLibraries.java
+ # (with the actual correct values) will be created when creating an apk.
+ jar_excluded_patterns = [
+ "*/BuildConfig.class",
+ "*/NativeLibraries.class",
+ "*/NativeLibraries##*.class",
+ ]
+ }
+
+ # Creates srcjar that contains sources for "base_java".
+ zip("base_java_srcjar") {
+ inputs = [
"android/java/src/org/chromium/base/ActivityState.java",
"android/java/src/org/chromium/base/AnimationFrameTimeHistogram.java",
"android/java/src/org/chromium/base/ApiCompatibilityUtils.java",
@@ -2326,14 +2338,8 @@ if (is_android) {
"android/java/src/org/chromium/base/metrics/RecordUserAction.java",
"android/java/src/org/chromium/base/multidex/ChromiumMultiDexInstaller.java",
]
-
- # New versions of BuildConfig.java and NativeLibraries.java
- # (with the actual correct values) will be created when creating an apk.
- jar_excluded_patterns = [
- "*/BuildConfig.class",
- "*/NativeLibraries.class",
- "*/NativeLibraries##*.class",
- ]
+ output = "$target_gen_dir/$target_name.srcjar"
+ base_dir = rebase_path("//base/android/java/src")
}
# GYP: //base.gyp:base_javatests
« no previous file with comments | « no previous file | components/cronet/android/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698