Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(736)

Issue 2347223002: Revert of Temporarily remove chrome_app_unittests from the Dr. Memory builder (Closed)

Created:
4 years, 3 months ago by tommycli
Modified:
4 years, 3 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Temporarily remove chrome_app_unittests from the Dr. Memory builder (patchset #1 id:1 of https://codereview.chromium.org/2278113002/ ) Reason for revert: Reverting, because Dr. Memory test bots need that executable. It didn't break until a clobber landed and deleted the executable generated in the past. Also glider@ reports that chrome_app_unittests was probably innocent (in the bug report) anyways. First breaking build: https://build.chromium.org/p/chromium.memory.full/builders/Windows%20Unit%20%28DrMemory%20full%29%20%285%29/builds/130 Original issue's description: > Temporarily remove chrome_app_unittests from the Dr. Memory builder > > BUG=640185 > TBR=dpranke@chromium.org > NOTRY=true > > Committed: https://crrev.com/ad1aac65be3a92db6e76bf62336569ee65246666 > Cr-Commit-Position: refs/heads/master@{#414420} TBR=dpranke@chromium.org,glider@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=640185 Committed: https://crrev.com/8baafc72ea7c28702b2090b34c187ef3bff6af02 Cr-Commit-Position: refs/heads/master@{#419220}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M testing/buildbot/chromium.full.json View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
tommycli
Created Revert of Temporarily remove chrome_app_unittests from the Dr. Memory builder
4 years, 3 months ago (2016-09-16 17:21:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2347223002/1
4 years, 3 months ago (2016-09-16 17:22:12 UTC) #3
Dirk Pranke
lgtm
4 years, 3 months ago (2016-09-16 17:45:26 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-16 18:27:23 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 18:29:44 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8baafc72ea7c28702b2090b34c187ef3bff6af02
Cr-Commit-Position: refs/heads/master@{#419220}

Powered by Google App Engine
This is Rietveld 408576698