Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Unified Diff: ios/chrome/browser/favicon/favicon_service_factory.cc

Issue 2347173002: Extend FaviconService to support fetching favicons from a Google server (Closed)
Patch Set: Peter's comments #2 Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/favicon/favicon_service_factory.cc
diff --git a/ios/chrome/browser/favicon/favicon_service_factory.cc b/ios/chrome/browser/favicon/favicon_service_factory.cc
index 0c72fd5137fd740c757d1db9aa1a45d7c2ef8c47..38d99e5653f3ab434996912ff72bb82a97dacb74 100644
--- a/ios/chrome/browser/favicon/favicon_service_factory.cc
+++ b/ios/chrome/browser/favicon/favicon_service_factory.cc
@@ -7,11 +7,14 @@
#include "base/memory/ptr_util.h"
#include "base/memory/singleton.h"
#include "components/favicon/core/favicon_service.h"
+#include "components/image_fetcher/image_decoder.h"
pkotwicz 2017/02/07 04:55:55 Nit: I think you don't need this include
+#include "components/image_fetcher/image_fetcher_impl.h"
#include "components/keyed_service/core/service_access_type.h"
#include "components/keyed_service/ios/browser_state_dependency_manager.h"
#include "ios/chrome/browser/browser_state/chrome_browser_state.h"
#include "ios/chrome/browser/favicon/favicon_client_impl.h"
#include "ios/chrome/browser/history/history_service_factory.h"
+#include "ios/chrome/browser/suggestions/ios_image_decoder_impl.h"
namespace ios {
@@ -55,7 +58,10 @@ std::unique_ptr<KeyedService> FaviconServiceFactory::BuildServiceInstanceFor(
return base::MakeUnique<favicon::FaviconService>(
base::MakeUnique<FaviconClientImpl>(),
jkrcal 2017/02/06 19:01:22 I am sorry, I've mixed in one rebase line.
ios::HistoryServiceFactory::GetForBrowserState(
- browser_state, ServiceAccessType::EXPLICIT_ACCESS));
+ browser_state, ServiceAccessType::EXPLICIT_ACCESS),
+ base::MakeUnique<image_fetcher::ImageFetcherImpl>(
+ base::MakeUnique<suggestions::IOSImageDecoderImpl>(),
+ browser_state->GetRequestContext()));
}
} // namespace ios

Powered by Google App Engine
This is Rietveld 408576698