Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Unified Diff: components/favicon_base/favicon_types.h

Issue 2347173002: Extend FaviconService to support fetching favicons from a Google server (Closed)
Patch Set: Peter's comments #2 Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/favicon_base/favicon_types.h
diff --git a/components/favicon_base/favicon_types.h b/components/favicon_base/favicon_types.h
index 6a399cefe0ebb4e03e6000ea79e6480a60862805..ddfef05f73629bfac9927e2f0188ce7f8dafd923 100644
--- a/components/favicon_base/favicon_types.h
+++ b/components/favicon_base/favicon_types.h
@@ -66,8 +66,15 @@ struct FaviconRawBitmapResult {
scoped_refptr<base::RefCountedMemory> bitmap_data;
// The pixel dimensions of |bitmap_data|.
+ // TODO(jkrcal): Remove this and only use pixel_size_in_db (crbug.com/675637).
gfx::Size pixel_size;
+ // The pixel dimensions of the bitmap stored in the database. Icons are
+ // resized prior to storing into the database so the dimensions are different
+ // than those of the bitmap at |icon_url|. The dimensions are taken prior to
+ // the resizing in FaviconService::Get###().
+ gfx::Size pixel_size_in_db;
+
// The URL of the containing favicon.
GURL icon_url;

Powered by Google App Engine
This is Rietveld 408576698