chrome/browser/android/favicon_helper.cc - Issue 2347173002: Extend FaviconService to support fetching favicons from a Google server

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/favicon_helper.cc

Issue 2347173002: Extend FaviconService to support fetching favicons from a Google server (Closed)

Patch Set: Peter's comments #2 Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/android/favicon_helper.cc

diff --git a/chrome/browser/android/favicon_helper.cc b/chrome/browser/android/favicon_helper.cc

index 6ac5e36478a9a393c173cb40f266e83b22226354..951c932bb34d58e0bec930d5ca84a5f1bb8e6d1e 100644

--- a/chrome/browser/android/favicon_helper.cc

+++ b/chrome/browser/android/favicon_helper.cc

@@ -150,6 +150,8 @@ ScopedJavaLocalRef<jobject> FaviconHelper::GetSyncedFaviconImageForURL(

return gfx::ConvertToJavaBitmap(&favicon_bitmap);

}

+// TODO(jkrcal): change this code to use

+// FaviconService::Get1xFaviconForPageURLDownloadFromGoogleServerIfMissing.

void FaviconHelper::EnsureIconIsAvailable(

JNIEnv* env,

const JavaParamRef<jobject>& obj,