Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/favicon/FaviconHelper.java

Issue 2347173002: Extend FaviconService to support fetching favicons from a Google server (Closed)
Patch Set: Peter's comments Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/favicon/FaviconHelper.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/favicon/FaviconHelper.java b/chrome/android/java/src/org/chromium/chrome/browser/favicon/FaviconHelper.java
index 3fbc9a5544fd3eb47ce1ed39e7a75821aa23c1d9..8a4cdef1b0da08934e90d4e81308d71d86da8faa 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/favicon/FaviconHelper.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/favicon/FaviconHelper.java
@@ -124,6 +124,8 @@ public class FaviconHelper {
* @param isTemporary Specifies whether the icon at iconUrl is temporary and should be updated
* as soon as the page at pageUrl is revisited.
* @param callback Called when completed (download not needed, finished or failed).
+ * TODO(jkrcal): change this code to use
+ * FaviconService::Get1xFaviconForPageURLDownloadFromGoogleServerIfMissing.
pkotwicz 2016/12/20 02:33:01 Super nit: I think that it makes more sense to hav
jkrcal 2017/02/06 19:01:22 Done.
*/
public void ensureIconIsAvailable(Profile profile, WebContents webContents, String pageUrl,
String iconUrl, boolean isLargeIcon, boolean isTemporary,
« no previous file with comments | « no previous file | chrome/browser/favicon/favicon_service_factory.cc » ('j') | components/favicon/core/favicon_service.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698