Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Unified Diff: tools/perf/page_sets/dual_browser_story.py

Issue 2347163003: Pass through in dual_browser_story for disabled benchmarks. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/page_sets/dual_browser_story.py
diff --git a/tools/perf/page_sets/dual_browser_story.py b/tools/perf/page_sets/dual_browser_story.py
index d21e0e666782eed1804a9ac989b92c4e5ca62e24..18ae6ad03a61c0a5ecdb84ad04e8c2915dc687e4 100644
--- a/tools/perf/page_sets/dual_browser_story.py
+++ b/tools/perf/page_sets/dual_browser_story.py
@@ -117,9 +117,7 @@ class MultiBrowserSharedState(story_module.SharedState):
if should_skip:
logging.warning(msg)
logging.warning('You are trying to run a disabled test.')
- logging.warning(
- 'Pass --also-run-disabled-tests to squelch this message.')
- sys.exit(0)
+ logging.warning('Valid chartjson ouput will not be generated.')
perezju 2016/09/29 13:01:45 This will effectively cause the benchmark to run e
eyaich1 2016/09/29 13:05:30 Well it won't fail, it will still technically succ
nednguyen 2016/09/29 13:08:40 Hmhh, why not define ShouldDisable(..) for the ben
def _PrepareBrowser(self, browser_type, options):
"""Add a browser to the dict of possible browsers.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698