s/NPN/ALPN/

s/NPN/ALPN/

s/RESPONSE_INFO_HAS_NPN_NEGOTIATED_PROTOCOL/RESPONSE_INFO_HAS_ALPN_NEGOTIATED_PROTOCOL/
s/RESPONSE_INFO_WAS_NPN/RESPONSE_INFO_WAS_ALPN/
s/was_npn_negotiated/was_alpn_negotiated/
s/npn_negotiated_protocol/alpn_negotiated_protocol/
s/ERR_NPN_NEGOTIATION_FAILED/ERR_ALPN_NEGOTIATION_FAILED/

WasNpnNegotiated and npnNegotiatedProtocol are not renamed in this CL,
because these names are exposed to the web platform,
and developers might depend on them.

BUG=526713
Committed: https://crrev.com/94c92849a971e1428dcd4b77e4118ac01b15b132
Cr-Commit-Position: refs/heads/master@{#420065}

[Bence, 2016-09-16 13:12:19]

The CQ bit was checked by bnc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-16 13:12:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-16 14:18:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-16 14:18:14]

Dry run: This issue passed the CQ dry run.

[Bence, 2016-09-16 14:30:10]

Description was changed from

==========
s/NPN/ALPN/

s/RESPONSE_INFO_HAS_NPN_NEGOTIATED_PROTOCOL/RESPONSE_INFO_HAS_ALPN_NEGOTIATED_PROTOCOL/
s/RESPONSE_INFO_WAS_NPN/RESPONSE_INFO_WAS_ALPN/

s/was_npn_negotiated/was_alpn_negotiated/
s/WasNpnNegotiated/WasAlpnNegotiated/

s/npn_negotiated_protocol/alpn_negotiated_protocol/
s/npnNegotiatedProtocol/alpnNegotiatedProtocol/

BUG=526713
==========

to

==========
s/NPN/ALPN/

s/RESPONSE_INFO_HAS_NPN_NEGOTIATED_PROTOCOL/RESPONSE_INFO_HAS_ALPN_NEGOTIATED_PROTOCOL/
s/RESPONSE_INFO_WAS_NPN/RESPONSE_INFO_WAS_ALPN/
s/was_npn_negotiated/was_alpn_negotiated/
s/npn_negotiated_protocol/alpn_negotiated_protocol/
s/ERR_NPN_NEGOTIATION_FAILED/ERR_ALPN_NEGOTIATION_FAILED/

I will rename WasNpnNegotiated and npnNegotiatedProtocol in a follow-up CL.

BUG=526713
==========

[Bence, 2016-09-16 14:31:12]

The CQ bit was checked by bnc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-16 14:31:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-16 15:41:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-16 15:41:14]

Dry run: This issue passed the CQ dry run.

[Bence, 2016-09-16 16:08:43]

bnc@chromium.org changed reviewers:
+ davidben@chromium.org

[Bence, 2016-09-16 16:09:06]

David: PTAL at net/.  Thank you.

[davidben, 2016-09-16 16:28:32]

net lgtm with comment

https://codereview.chromium.org/2347163002/diff/80001/net/base/net_error_list.h
File net/base/net_error_list.h (right):

https://codereview.chromium.org/2347163002/diff/80001/net/base/net_error_list...
net/base/net_error_list.h:193: NET_ERROR(ALPN_NEGOTIATION_FAILED, -122)
Could you re-run tools/metrics/histograms/update_net_error_codes.py?

[Bence, 2016-09-16 17:20:00]

bnc@chromium.org changed reviewers:
+ clamy@chromium.org, csharrison@chromium.org, kapishnikov@chromium.org,
mbarbella@chromium.org

[Bence, 2016-09-16 17:20:01]

kapishnikov: PTAL at components/cronet/android/
clamy: PTAL at content/ except for content/common/
Martin: PTAL at content/common/resource_messages.h
Charlie: PTA at chrome/renderer/loadtimes_extension_bindings.cc

Thank you all, and have a nice weekend.

[Martin Barbella, 2016-09-16 17:21:44]

resource_messages.h lgtm

[Bence, 2016-09-16 17:26:26]

bnc@chromium.org changed reviewers:
+ holte@chromium.org

[Bence, 2016-09-16 17:26:28]

Steven: PTAL at tools/metrics/histograms/histograms.xml.  Thank you.

[Charlie Harrison, 2016-09-16 17:28:03]

csharrison@chromium.org changed reviewers:
+ bmcquade@chromium.org

[Charlie Harrison, 2016-09-16 17:28:03]

bmcquade knows this code more than I do. Deferring to him.

[Steven Holte, 2016-09-16 18:55:54]

histograms lgtm

[Bryan McQuade, 2016-09-16 18:59:05]

loadtimes_extension_bindings LGTM. Thanks for not renaming the wasNpnNegotiated
and other properties exposed to the web platform, as devs may be depending on
these names.

cc'ing panicker and igrigorik as FYI - do we have a plan to migrate these
NPN/ALPN properties to another standardized API?

[davidben, 2016-09-16 19:05:53]

On 2016/09/16 18:59:05, Bryan McQuade wrote:
> loadtimes_extension_bindings LGTM. Thanks for not renaming the
wasNpnNegotiated
> and other properties exposed to the web platform, as devs may be depending on
> these names.
> 
> cc'ing panicker and igrigorik as FYI - do we have a plan to migrate these
> NPN/ALPN properties to another standardized API?

This doesn't seem like a good thing to expose without very clear use cases. I
might load a resource entirely from cache. I might load a resource stitching
together multiple requests (cache ranges stuff) that happened to go to different
sockets which negotiate different protocols because the server is
mid-field-trial. What's this field report in those cases? I imagine we just made
something up right now based on what's convenient, but standardizing the
behavior means we have no option if we need to rearchitect later. In general,
exposing every random thing we've got in hopes it might be useful is a
problematic strategy for stable platform.

Meanwhile, the server is already in a position where it knows exactly what
happened because it was the one that selected the protocol anyway.

[panicker, 2016-09-16 19:55:58]

On 2016/09/16 19:05:53, davidben wrote:
> On 2016/09/16 18:59:05, Bryan McQuade wrote:
> > loadtimes_extension_bindings LGTM. Thanks for not renaming the
> wasNpnNegotiated
> > and other properties exposed to the web platform, as devs may be depending
on
> > these names.
> > 
> > cc'ing panicker and igrigorik as FYI - do we have a plan to migrate these
> > NPN/ALPN properties to another standardized API?
> 
> This doesn't seem like a good thing to expose without very clear use cases. I
> might load a resource entirely from cache. I might load a resource stitching
> together multiple requests (cache ranges stuff) that happened to go to
different
> sockets which negotiate different protocols because the server is
> mid-field-trial. What's this field report in those cases? I imagine we just
made
> something up right now based on what's convenient, but standardizing the
> behavior means we have no option if we need to rearchitect later. In general,
> exposing every random thing we've got in hopes it might be useful is a
> problematic strategy for stable platform.
> 
> Meanwhile, the server is already in a position where it knows exactly what
> happened because it was the one that selected the protocol anyway.

Currently we have nextHopProtocol as the closest thing:
https://w3c.github.io/resource-timing/#dom-performanceresourcetiming-nexthopp...

[clamy, 2016-09-19 09:54:02]

Thanks! content/ lgtm

[Bence, 2016-09-19 12:00:02]

Description was changed from

==========
s/NPN/ALPN/

s/RESPONSE_INFO_HAS_NPN_NEGOTIATED_PROTOCOL/RESPONSE_INFO_HAS_ALPN_NEGOTIATED_PROTOCOL/
s/RESPONSE_INFO_WAS_NPN/RESPONSE_INFO_WAS_ALPN/
s/was_npn_negotiated/was_alpn_negotiated/
s/npn_negotiated_protocol/alpn_negotiated_protocol/
s/ERR_NPN_NEGOTIATION_FAILED/ERR_ALPN_NEGOTIATION_FAILED/

I will rename WasNpnNegotiated and npnNegotiatedProtocol in a follow-up CL.

BUG=526713
==========

to

==========
s/NPN/ALPN/

s/RESPONSE_INFO_HAS_NPN_NEGOTIATED_PROTOCOL/RESPONSE_INFO_HAS_ALPN_NEGOTIATED_PROTOCOL/
s/RESPONSE_INFO_WAS_NPN/RESPONSE_INFO_WAS_ALPN/
s/was_npn_negotiated/was_alpn_negotiated/
s/npn_negotiated_protocol/alpn_negotiated_protocol/
s/ERR_NPN_NEGOTIATION_FAILED/ERR_ALPN_NEGOTIATION_FAILED/

WasNpnNegotiated and npnNegotiatedProtocol are not renamed in this CL, because
these names are exposed to the web platform, and developers might depend on
them.

BUG=526713
==========

[Bence, 2016-09-19 12:00:33]

Description was changed from

==========
s/NPN/ALPN/

s/RESPONSE_INFO_HAS_NPN_NEGOTIATED_PROTOCOL/RESPONSE_INFO_HAS_ALPN_NEGOTIATED_PROTOCOL/
s/RESPONSE_INFO_WAS_NPN/RESPONSE_INFO_WAS_ALPN/
s/was_npn_negotiated/was_alpn_negotiated/
s/npn_negotiated_protocol/alpn_negotiated_protocol/
s/ERR_NPN_NEGOTIATION_FAILED/ERR_ALPN_NEGOTIATION_FAILED/

WasNpnNegotiated and npnNegotiatedProtocol are not renamed in this CL, because
these names are exposed to the web platform, and developers might depend on
them.

BUG=526713
==========

to

==========
s/NPN/ALPN/

s/RESPONSE_INFO_HAS_NPN_NEGOTIATED_PROTOCOL/RESPONSE_INFO_HAS_ALPN_NEGOTIATED_PROTOCOL/
s/RESPONSE_INFO_WAS_NPN/RESPONSE_INFO_WAS_ALPN/
s/was_npn_negotiated/was_alpn_negotiated/
s/npn_negotiated_protocol/alpn_negotiated_protocol/
s/ERR_NPN_NEGOTIATION_FAILED/ERR_ALPN_NEGOTIATION_FAILED/

WasNpnNegotiated and npnNegotiatedProtocol are not renamed in this CL,
because these names are exposed to the web platform,
and developers might depend on them.

BUG=526713
==========

[kapishnikov, 2016-09-20 16:38:32]

lgtm

[Bence, 2016-09-20 16:48:10]

The CQ bit was checked by bnc@chromium.org

[Bence, 2016-09-20 16:48:11]

The patchset sent to the CQ was uploaded after l-g-t-m from
mbarbella@chromium.org, davidben@chromium.org
Link to the patchset: https://codereview.chromium.org/2347163002/#ps100001
(title: "Re: #12.")

[commit-bot: I haz the power, 2016-09-20 16:48:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 18:13:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 18:13:22]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Bence, 2016-09-21 14:18:22]

The CQ bit was checked by bnc@chromium.org

[commit-bot: I haz the power, 2016-09-21 14:18:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 15:23:13]

Description was changed from

==========
s/NPN/ALPN/

s/RESPONSE_INFO_HAS_NPN_NEGOTIATED_PROTOCOL/RESPONSE_INFO_HAS_ALPN_NEGOTIATED_PROTOCOL/
s/RESPONSE_INFO_WAS_NPN/RESPONSE_INFO_WAS_ALPN/
s/was_npn_negotiated/was_alpn_negotiated/
s/npn_negotiated_protocol/alpn_negotiated_protocol/
s/ERR_NPN_NEGOTIATION_FAILED/ERR_ALPN_NEGOTIATION_FAILED/

WasNpnNegotiated and npnNegotiatedProtocol are not renamed in this CL,
because these names are exposed to the web platform,
and developers might depend on them.

BUG=526713
==========

to

==========
s/NPN/ALPN/

s/RESPONSE_INFO_HAS_NPN_NEGOTIATED_PROTOCOL/RESPONSE_INFO_HAS_ALPN_NEGOTIATED_PROTOCOL/
s/RESPONSE_INFO_WAS_NPN/RESPONSE_INFO_WAS_ALPN/
s/was_npn_negotiated/was_alpn_negotiated/
s/npn_negotiated_protocol/alpn_negotiated_protocol/
s/ERR_NPN_NEGOTIATION_FAILED/ERR_ALPN_NEGOTIATION_FAILED/

WasNpnNegotiated and npnNegotiatedProtocol are not renamed in this CL,
because these names are exposed to the web platform,
and developers might depend on them.

BUG=526713
==========

[commit-bot: I haz the power, 2016-09-21 15:23:15]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-09-21 15:25:03]

Description was changed from

==========
s/NPN/ALPN/

s/RESPONSE_INFO_HAS_NPN_NEGOTIATED_PROTOCOL/RESPONSE_INFO_HAS_ALPN_NEGOTIATED_PROTOCOL/
s/RESPONSE_INFO_WAS_NPN/RESPONSE_INFO_WAS_ALPN/
s/was_npn_negotiated/was_alpn_negotiated/
s/npn_negotiated_protocol/alpn_negotiated_protocol/
s/ERR_NPN_NEGOTIATION_FAILED/ERR_ALPN_NEGOTIATION_FAILED/

WasNpnNegotiated and npnNegotiatedProtocol are not renamed in this CL,
because these names are exposed to the web platform,
and developers might depend on them.

BUG=526713
==========

to

==========
s/NPN/ALPN/

s/RESPONSE_INFO_HAS_NPN_NEGOTIATED_PROTOCOL/RESPONSE_INFO_HAS_ALPN_NEGOTIATED_PROTOCOL/
s/RESPONSE_INFO_WAS_NPN/RESPONSE_INFO_WAS_ALPN/
s/was_npn_negotiated/was_alpn_negotiated/
s/npn_negotiated_protocol/alpn_negotiated_protocol/
s/ERR_NPN_NEGOTIATION_FAILED/ERR_ALPN_NEGOTIATION_FAILED/

WasNpnNegotiated and npnNegotiatedProtocol are not renamed in this CL,
because these names are exposed to the web platform,
and developers might depend on them.

BUG=526713

Committed: https://crrev.com/94c92849a971e1428dcd4b77e4118ac01b15b132
Cr-Commit-Position: refs/heads/master@{#420065}
==========

[commit-bot: I haz the power, 2016-09-21 15:25:05]

Patchset 6 (id:??) landed as
https://crrev.com/94c92849a971e1428dcd4b77e4118ac01b15b132
Cr-Commit-Position: refs/heads/master@{#420065}