Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 2347153002: Tweak valgrind suppressions for intentional leaks. (Closed)

Created:
4 years, 3 months ago by mtklein_C
Modified:
4 years, 3 months ago
Reviewers:
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Tweak valgrind suppressions for intentional leaks. This is a follow up to building the Valgrind bots with GN. It's not clear why these need to leak, but we might as well update the suppressions. The stacks now look like this: Memcheck:Leak match-leak-kinds: possible fun:calloc fun:_dl_allocate_tls fun:pthread_create@@GLIBC_2.2.5 fun:_ZN8SkThreadC1EPFvPvES0_ fun:_Z14nanobench_mainv fun:(below main) We suppress fun:main in that last slot, so just make it ... TBR= BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2347153002 Committed: https://skia.googlesource.com/skia/+/e14e226ba738c3c0faa9ab6ec7bd4234d2574e46

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M tools/valgrind.supp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2347153002/1
4 years, 3 months ago (2016-09-16 12:13:38 UTC) #4
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 12:47:08 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/e14e226ba738c3c0faa9ab6ec7bd4234d2574e46

Powered by Google App Engine
This is Rietveld 408576698