test/cctest/interpreter/bytecode_expectations/LookupSlotWideInEval.golden - Issue 2347143002: [interpreter] Add fast path for dynamic global lookups

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/interpreter/bytecode_expectations/LookupSlotWideInEval.golden

Issue 2347143002: [interpreter] Add fast path for dynamic global lookups (Closed)

Patch Set: Fix comments and some inlining of methods Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« src/interpreter/interpreter.cc ('K') | « test/cctest/interpreter/bytecode_expectations/LookupSlotInEval.golden ('k') | test/cctest/interpreter/test-bytecode-generator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: test/cctest/interpreter/bytecode_expectations/LookupSlotWideInEval.golden

diff --git a/test/cctest/interpreter/bytecode_expectations/LookupSlotWideInEval.golden b/test/cctest/interpreter/bytecode_expectations/LookupSlotWideInEval.golden

index 53bd727dd72fd859e0c9ac2bfe092afe8df682dc..86e9410101fbdcfdef79774166eb12648e27133e 100644

--- a/test/cctest/interpreter/bytecode_expectations/LookupSlotWideInEval.golden

+++ b/test/cctest/interpreter/bytecode_expectations/LookupSlotWideInEval.golden

@@ -278,7 +278,7 @@ snippet: "

frame size: 1

parameter count: 1

-bytecode array length: 1030

+bytecode array length: 1034

bytecodes: [

/* 10 E> */ B(StackCheck),

/* 22 S> */ B(LdaConstant), U8(0),

@@ -793,7 +793,7 @@ bytecodes: [

B(Star), R(0),

/* 3082 S> */ B(LdaConstant), U8(255),

B(Star), R(0),

- /* 3086 S> */ B(Wide), B(LdaLookupSlot), U16(256),

+ /* 3086 S> */ B(Wide), B(LdaLookupGlobalSlot), U16(256), U16(2), U16(1),

/* 3095 S> */ B(Return),

]

constant pool: [

@@ -1329,7 +1329,7 @@ snippet: "

frame size: 1

parameter count: 1

-bytecode array length: 1031

+bytecode array length: 1035

bytecodes: [

/* 10 E> */ B(StackCheck),

/* 22 S> */ B(LdaConstant), U8(0),

@@ -1844,7 +1844,7 @@ bytecodes: [

B(Star), R(0),

/* 3082 S> */ B(LdaConstant), U8(255),

B(Star), R(0),

- /* 3086 S> */ B(Wide), B(LdaLookupSlotInsideTypeof), U16(256),

+ /* 3086 S> */ B(Wide), B(LdaLookupGlobalSlotInsideTypeof), U16(256), U16(2), U16(1),

B(TypeOf),

/* 3102 S> */ B(Return),

]