[interpreter] Add fast path for dynamic global lookups

src/interpreter/interpreter.h

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_INTERPRETER_INTERPRETER_H_
 #define V8_INTERPRETER_INTERPRETER_H_
 
 #include <memory>
 
 // Clients of this interface shouldn't depend on lots of interpreter internals.
@@ skipping 110 matching lines @@
   // Generates code to perform a keyed property store via |ic|.
   void DoKeyedStoreIC(Callable ic, InterpreterAssembler* assembler);
 
   // Generates code to perform a JS call that collects type feedback.
   void DoJSCall(InterpreterAssembler* assembler, TailCallMode tail_call_mode);
 
   // Generates code to perform delete via function_id.
   void DoDelete(Runtime::FunctionId function_id,
                 InterpreterAssembler* assembler);
 
+  // Generates code to perform a lookup slot load via |function_id| by calling
+  // out to the runtime.
+  void DoLdaLookupSlowPath(Runtime::FunctionId function_id,
+                           compiler::Node* name_index, compiler::Node* context,
+                           InterpreterAssembler* assembler);
+
   // Generates code to perform a lookup slot load via |function_id|.
   void DoLdaLookupSlot(Runtime::FunctionId function_id,
                        InterpreterAssembler* assembler);
 
   // Generates code to perform a lookup slot load via |function_id| that can
   // fast path to a context slot load.
   void DoLdaLookupContextSlot(Runtime::FunctionId function_id,
                               InterpreterAssembler* assembler);
 
-  // Generates code to perform a lookup slot store depending on |language_mode|.
+  // Generates code to perform a lookup slot load via |function_id| that can
+  // fast path to a global load

[rmcilroy, 2016/09/19 09:04:29]

fullstop

[Leszek Swirski, 2016/09/19 10:34:51]

Obsolete, function got removed.

+  void DoLdaLookupGlobalSlot(Runtime::FunctionId function_id,
+                             InterpreterAssembler* assembler);
+
+  // Generates code to perform a lookup slot store depending on
+  // |language_mode|.
   void DoStaLookupSlot(LanguageMode language_mode,
                        InterpreterAssembler* assembler);
 
   // Generates code to load a context slot.
   compiler::Node* BuildLoadContextSlot(InterpreterAssembler* assembler);
 
   // Generates code to load a global.
+  compiler::Node* BuildLoadGlobal(Callable ic, compiler::Node* context,
+                                  compiler::Node* raw_slot,
+                                  InterpreterAssembler* assembler);
+
+  // Generates code to load a global.
   compiler::Node* BuildLoadGlobal(Callable ic, InterpreterAssembler* assembler);
 
   // Generates code to load a named property.
   compiler::Node* BuildLoadNamedProperty(Callable ic,
                                          InterpreterAssembler* assembler);
 
   // Generates code to load a keyed property.
   compiler::Node* BuildLoadKeyedProperty(Callable ic,
                                          InterpreterAssembler* assembler);
 
@@ skipping 27 matching lines @@
   std::unique_ptr<uintptr_t[]> bytecode_dispatch_counters_table_;
 
   DISALLOW_COPY_AND_ASSIGN(Interpreter);
 };
 
 }  // namespace interpreter
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_INTERPRETER_INTERPRETER_H_