Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2347133004: Allow input summaries to be specified when running analyzer_cli in non-build mode. (Closed)

Created:
4 years, 3 months ago by Paul Berry
Modified:
4 years, 3 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Allow input summaries to be specified when running analyzer_cli in non-build mode. R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/f7a12f9c83754085971e215e4753fac98925f3ad

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -5 lines) Patch
M pkg/analyzer_cli/lib/src/driver.dart View 8 chunks +41 lines, -5 lines 2 comments Download
M pkg/analyzer_cli/test/options_test.dart View 2 chunks +21 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Paul Berry
4 years, 3 months ago (2016-09-16 19:05:31 UTC) #2
Brian Wilkerson
lgtm https://codereview.chromium.org/2347133004/diff/1/pkg/analyzer_cli/lib/src/driver.dart File pkg/analyzer_cli/lib/src/driver.dart (right): https://codereview.chromium.org/2347133004/diff/1/pkg/analyzer_cli/lib/src/driver.dart#newcode522 pkg/analyzer_cli/lib/src/driver.dart:522: 'Summaries are not supported in this configuration'); Could ...
4 years, 3 months ago (2016-09-16 19:27:30 UTC) #3
Paul Berry
https://codereview.chromium.org/2347133004/diff/1/pkg/analyzer_cli/lib/src/driver.dart File pkg/analyzer_cli/lib/src/driver.dart (right): https://codereview.chromium.org/2347133004/diff/1/pkg/analyzer_cli/lib/src/driver.dart#newcode522 pkg/analyzer_cli/lib/src/driver.dart:522: 'Summaries are not supported in this configuration'); On 2016/09/16 ...
4 years, 3 months ago (2016-09-16 21:50:14 UTC) #4
Paul Berry
4 years, 3 months ago (2016-09-19 19:39:30 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
f7a12f9c83754085971e215e4753fac98925f3ad (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698