Issue 2347123004: Issue 27374. Include all configuration sources into REFERENCED_SOURCES.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2347123004: Issue 27374. Include all configuration sources into REFERENCED_SOURCES. (Closed)

Created:
4 years, 3 months ago by scheglov

Modified:
4 years, 3 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Issue 27374. Include all configuration sources into REFERENCED_SOURCES. VerifyUnitTask verifies all Configuration sources, so we need to know MODIFICATION_TIME all the sources, even if the configuration is not selected. R=brianwilkerson@google.com BUG= https://github.com/dart-lang/sdk/issues/27374 Committed: https://github.com/dart-lang/sdk/commit/ea0d3e44300f65f0b8f44da5852857fbc840a019

Created: 4 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -8 lines)			Patch
	M	pkg/analyzer/lib/src/task/dart.dart	View		2 chunks	+21 lines, -8 lines	0 comments	Download
	M	pkg/analyzer/test/src/task/dart_test.dart	View		1 chunk	+10 lines, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

scheglov

4 years, 3 months ago (2016-09-16 18:31:39 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
ea0d3e44300f65f0b8f44da5852857fbc840a019 (presubmit successful).