Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 2347113002: Remove unused enum in RemoteFontFaceSource::FontLoadHistograms (Closed)

Created:
4 years, 3 months ago by Shao-Chuan Lee
Modified:
4 years, 3 months ago
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis, Takashi Toyoshima
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused enum in RemoteFontFaceSource::FontLoadHistograms Now using CacheHitMetrics instead of local enum. Fixup for https://crrev.com/2289303004. Committed: https://crrev.com/25b5f0119a11dceb1347e43bcc8b4c3c0301a7a7 Cr-Commit-Position: refs/heads/master@{#419121}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M third_party/WebKit/Source/core/css/RemoteFontFaceSource.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
Shao-Chuan Lee
PTAL
4 years, 3 months ago (2016-09-16 04:53:14 UTC) #3
Kunihiko Sakamoto
lgtm
4 years, 3 months ago (2016-09-16 04:57:31 UTC) #4
Shao-Chuan Lee
haraken@chromium.org: needs OWNERS review, PTAL, thanks.
4 years, 3 months ago (2016-09-16 05:00:40 UTC) #6
haraken
LGTM
4 years, 3 months ago (2016-09-16 06:02:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2347113002/1
4 years, 3 months ago (2016-09-16 06:02:41 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-16 07:08:07 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 07:09:55 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/25b5f0119a11dceb1347e43bcc8b4c3c0301a7a7
Cr-Commit-Position: refs/heads/master@{#419121}

Powered by Google App Engine
This is Rietveld 408576698