Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1019)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2347103003: Implement the MediaStreamTrackEvent constructor (Closed)

Created:
4 years, 3 months ago by foolip
Modified:
4 years, 3 months ago
CC:
chromium-reviews, blink-reviews-w3ctests_chromium.org, tfarina, haraken, tommyw+watchlist_chromium.org, blink-reviews, mcasas+watch+mediastream_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement the MediaStreamTrackEvent constructor Intent to Implement and Ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/tfnjsv9jKVg/ZJ79fG_yAQAJ BUG=646837 Committed: https://crrev.com/3e97df71c62e1626b87744e93b2614ae65cdace7 Cr-Commit-Position: refs/heads/master@{#420421}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : update webexposed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -33 lines) Patch
D third_party/WebKit/LayoutTests/imported/wpt/mediacapture-streams/MediaStreamTrackEvent-constructor.https-expected.txt View 1 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/MediaStream.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/MediaStreamEvent.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/MediaStreamEvent.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/MediaStreamTrackEvent.h View 3 chunks +5 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/MediaStreamTrackEvent.cpp View 1 chunk +17 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/MediaStreamTrackEvent.idl View 1 chunk +5 lines, -2 lines 0 comments Download
A + third_party/WebKit/Source/modules/mediastream/MediaStreamTrackEventInit.idl View 1 chunk +3 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/modules/modules_idl_files.gni View 1 2 2 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
foolip
PTAL
4 years, 3 months ago (2016-09-22 13:13:55 UTC) #7
Guido Urdaneta
lgtm
4 years, 3 months ago (2016-09-22 13:33:11 UTC) #8
foolip
On 2016/09/22 13:33:11, Guido Urdaneta wrote: > lgtm Thanks, now just waiting for LGTM3 on ...
4 years, 3 months ago (2016-09-22 13:46:30 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2347103003/40001
4 years, 3 months ago (2016-09-22 15:06:41 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-22 19:16:19 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-09-22 19:18:14 UTC) #15
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/3e97df71c62e1626b87744e93b2614ae65cdace7
Cr-Commit-Position: refs/heads/master@{#420421}

Powered by Google App Engine
This is Rietveld 408576698