Issue 23471009: Add a DCHECK to RenderWidgetHost::FromID to ensure that it's only called on the UI thread.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23471009: Add a DCHECK to RenderWidgetHost::FromID to ensure that it's only called on the UI thread. (Closed)

Created:
7 years, 3 months ago by jam

Modified:
7 years, 3 months ago

Reviewers:
Avi (use Gerrit)

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Add a DCHECK to RenderWidgetHost::FromID to ensure that it's only called on the UI thread. R=avi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221750

Patch Set 1 #

Patch Set 2 : disable usage from IO thread #

Patch Set 3 : sync to fix at r221724 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	content/browser/renderer_host/render_widget_host_impl.cc	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

jam

On 2013/09/06 05:23:55, jam wrote: > I thought we already had this but turned out ...

7 years, 3 months ago (2013-09-06 06:26:01 UTC) #2

Avi (use Gerrit)

Um, sure, happy to have inspired this through my clumsy CL :) LGTM

7 years, 3 months ago (2013-09-06 14:59:34 UTC) #3

jam

On 2013/09/06 14:59:34, Avi wrote: > Um, sure, happy to have inspired this through my ...

7 years, 3 months ago (2013-09-06 16:00:31 UTC) #4

Avi (use Gerrit)

7 years, 3 months ago (2013-09-06 16:02:22 UTC) #5

On 2013/09/06 16:00:31, jam wrote:
> On 2013/09/06 14:59:34, Avi wrote:
> > Um, sure, happy to have inspired this through my clumsy CL :)
> > 
> > LGTM
> 
> I was surprised that you hadn't gotten a dcheck, since this path used to
check.
> I looked through the history and found that r207913 refactored some code, and
we
> were depending on the dcheck in RenderProcessHost::FromID's dcheck which
wasn't
> being used anymore :)

Oh, you were thinking that I'd _run_ that CL? I tossed it to you and shishir to
get your thoughts after getting it to compile.

Expand Messages | Collapse Messages