base/debug/crash_logging.h - Issue 23471007: Set active extension IDs for crash reports using the crash key logging system.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/debug/crash_logging.h

Issue 23471007: Set active extension IDs for crash reports using the crash key logging system. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: base::snprintf Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/debug/crash_logging.h

diff --git a/base/debug/crash_logging.h b/base/debug/crash_logging.h

index 376d0116553acc9cb183200566ad4f7c3b64cbf5..90e6687bec8cdfd50fd629e0fe9e06996c05f6a4 100644

--- a/base/debug/crash_logging.h

+++ b/base/debug/crash_logging.h

@@ -56,7 +56,7 @@ class BASE_EXPORT ScopedCrashKey {

// Before setting values for a key, all the keys must be registered.

struct BASE_EXPORT CrashKey {

// The name of the crash key, used in the above functions.

- const char* const key_name;

Robert Sesek 2013/09/06 20:20:59 Not a huge fan of this, but it's necessary for it

Mark Mentovai 2013/09/06 20:50:05 rsesek wrote:

+ const char* key_name;

// The maximum length for a value. If the value is longer than this, it will

// be truncated. If the value is larger than the |chunk_max_length| passed to

« no previous file with comments | « no previous file | chrome/app/breakpad_linux.cc » ('j') | chrome/common/crash_keys.h » ('J')