Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2503)

Unified Diff: ash/wm/workspace/snap_sizer_unittest.cc

Issue 23471004: Only support left/right maximizing at 50% width when the --ash-enable-alternate-caption-button (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: A lot less code :) Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/wm/workspace/snap_sizer_unittest.cc
diff --git a/ash/wm/workspace/snap_sizer_unittest.cc b/ash/wm/workspace/snap_sizer_unittest.cc
index f3879c44fb93a4d55b62a2a81a551c3bda603b00..20a917e04adb62fa2afd87721cd2551c86ed2b44 100644
--- a/ash/wm/workspace/snap_sizer_unittest.cc
+++ b/ash/wm/workspace/snap_sizer_unittest.cc
@@ -4,10 +4,12 @@
#include "ash/wm/workspace/snap_sizer.h"
+#include "ash/ash_switches.h"
#include "ash/screen_ash.h"
#include "ash/shell.h"
#include "ash/test/ash_test_base.h"
#include "ash/wm/window_util.h"
+#include "base/command_line.h"
#include "ui/aura/root_window.h"
#include "ui/aura/test/test_window_delegate.h"
#include "ui/aura/window.h"
@@ -97,4 +99,80 @@ TEST_F(SnapSizerTest, MinimumSize) {
EXPECT_FALSE(ash::wm::CanSnapWindow(window.get()));
}
+// Test that repeadedly calling SnapSizer::SnapWindow() steps through the ideal
+// widths in descending order as well as 90% and 50% of the work area's width.
+TEST_F(SnapSizerTest, StepThroughSizes) {
+ if (!SupportsHostWindowResize())
+ return;
+
+ UpdateDisplay("0+0-1024x800");
+ const gfx::Rect kWorkAreaBounds =
+ ash::Shell::GetScreen()->GetPrimaryDisplay().work_area();
+
+ scoped_ptr<aura::Window> window(
+ CreateTestWindowInShellWithBounds(gfx::Rect(100, 100, 100, 100)));
+
+ // We start with the smallest width first before wrapping around.
+ // TODO: Investigate whether this is intentional.
+ SnapSizer::SnapWindow(window.get(), SnapSizer::LEFT_EDGE);
+ gfx::Rect expected = gfx::Rect(kWorkAreaBounds.x(),
+ kWorkAreaBounds.y(),
+ 512,
+ kWorkAreaBounds.height());
+ EXPECT_EQ(expected.ToString(), window->GetBoundsInScreen().ToString());
+
+ SnapSizer::SnapWindow(window.get(), SnapSizer::LEFT_EDGE);
+ expected.set_width(921);
+ EXPECT_EQ(expected.ToString(), window->GetBoundsInScreen().ToString());
+
+ SnapSizer::SnapWindow(window.get(), SnapSizer::LEFT_EDGE);
+ expected.set_width(768);
+ EXPECT_EQ(expected.ToString(), window->GetBoundsInScreen().ToString());
+
+ SnapSizer::SnapWindow(window.get(), SnapSizer::LEFT_EDGE);
+ expected.set_width(640);
+ EXPECT_EQ(expected.ToString(), window->GetBoundsInScreen().ToString());
+
+ SnapSizer::SnapWindow(window.get(), SnapSizer::LEFT_EDGE);
+ expected.set_width(512);
+ EXPECT_EQ(expected.ToString(), window->GetBoundsInScreen().ToString());
+}
+
+// Test that the window only snaps to 50% of the work area width when using the
+// alternate caption button style.
+TEST_F(SnapSizerTest, AlternateFrameCaptionButtonStyle) {
+ if (!SupportsHostWindowResize())
+ return;
+
+ CommandLine::ForCurrentProcess()->AppendSwitch(
+ ash::switches::kAshEnableAlternateFrameCaptionButtonStyle);
+ ASSERT_TRUE(ash::switches::UseAlternateFrameCaptionButtonStyle());
+
+ UpdateDisplay("0+0-800x600");
+ const gfx::Rect kWorkAreaBounds =
+ ash::Shell::GetScreen()->GetPrimaryDisplay().work_area();
+
+ scoped_ptr<aura::Window> window(
+ CreateTestWindowInShellWithBounds(gfx::Rect(100, 100, 100, 100)));
+
+ SnapSizer::SnapWindow(window.get(), SnapSizer::LEFT_EDGE);
+ gfx::Rect expected = gfx::Rect(kWorkAreaBounds.x(),
+ kWorkAreaBounds.y(),
+ kWorkAreaBounds.width() / 2,
+ kWorkAreaBounds.height());
+ EXPECT_EQ(expected.ToString(), window->GetBoundsInScreen().ToString());
+
+ // Because a window can only be snapped to one size when using the alternate
+ // caption button style, a second call to SnapSizer::SnapWindow() should have
+ // no effect.
+ SnapSizer::SnapWindow(window.get(), SnapSizer::LEFT_EDGE);
+ EXPECT_EQ(expected.ToString(), window->GetBoundsInScreen().ToString());
+
+ // It should still be possible to switch a window from being snapped to the
+ // left edge to being snapped to the right edge.
+ SnapSizer::SnapWindow(window.get(), SnapSizer::LEFT_EDGE);
+ expected.set_x(expected.right() - expected.width());
+ EXPECT_EQ(expected.ToString(), window->GetBoundsInScreen().ToString());
+}
+
} // namespace ash

Powered by Google App Engine
This is Rietveld 408576698