Only support left/right maximizing at 50% width when the --ash-enable-alternate-caption-button

ash/wm/custom_frame_view_ash_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/wm/custom_frame_view_ash.h"
 
 #include "ash/shell.h"
 #include "ash/test/ash_test_base.h"
 #include "ash/wm/maximize_bubble_controller.h"
 #include "ash/wm/property_util.h"
 #include "ash/wm/window_util.h"
 #include "ash/wm/workspace/frame_caption_button_container_view.h"
 #include "ash/wm/workspace/frame_maximize_button.h"
-#include "ash/wm/workspace/snap_sizer.h"
 #include "base/command_line.h"
 #include "ui/aura/client/aura_constants.h"
 #include "ui/aura/client/focus_client.h"
 #include "ui/aura/test/event_generator.h"
 #include "ui/aura/root_window.h"
 #include "ui/aura/window.h"
 #include "ui/base/events/event_utils.h"
 #include "ui/base/gestures/gesture_configuration.h"
 #include "ui/views/controls/button/image_button.h"
 #include "ui/views/widget/widget.h"
@@ skipping 167 matching lines @@
 
   // Snap right.
   {
     generator.PressLeftButton();
     generator.MoveMouseBy(10, 0);
     generator.ReleaseLeftButton();
     RunAllPendingInMessageLoop();
 
     EXPECT_FALSE(ash::wm::IsWindowMaximized(window));
     EXPECT_FALSE(ash::wm::IsWindowMinimized(window));
-    internal::SnapSizer sizer(window, center,
-        internal::SnapSizer::RIGHT_EDGE,
-        internal::SnapSizer::OTHER_INPUT);
-    EXPECT_EQ(sizer.target_bounds().ToString(), window->bounds().ToString());
+    gfx::Rect target_bounds = ash::wm::GetSnappedWindowBoundsInParent(
+        window, ash::wm::SNAP_RIGHT_EDGE);
+    EXPECT_EQ(target_bounds.ToString(), window->bounds().ToString());
   }
 
   // Snap left.
   {
     center = view->GetBoundsInScreen().CenterPoint();
     generator.MoveMouseTo(center);
     generator.PressLeftButton();
     generator.MoveMouseBy(-10, 0);
     generator.ReleaseLeftButton();
     RunAllPendingInMessageLoop();
 
     EXPECT_FALSE(ash::wm::IsWindowMaximized(window));
     EXPECT_FALSE(ash::wm::IsWindowMinimized(window));
-    internal::SnapSizer sizer(window, center,
-        internal::SnapSizer::LEFT_EDGE,
-        internal::SnapSizer::OTHER_INPUT);
-    EXPECT_EQ(sizer.target_bounds().ToString(), window->bounds().ToString());
+    gfx::Rect target_bounds = ash::wm::GetSnappedWindowBoundsInParent(
+        window, ash::wm::SNAP_LEFT_EDGE);
+    EXPECT_EQ(target_bounds.ToString(), window->bounds().ToString());
   }
 
   // Minimize.
   {
     center = view->GetBoundsInScreen().CenterPoint();
     generator.MoveMouseTo(center);
     generator.PressLeftButton();
     generator.MoveMouseBy(0, 10);
     generator.ReleaseLeftButton();
     RunAllPendingInMessageLoop();
@@ skipping 10 matching lines @@
     center = view->GetBoundsInScreen().CenterPoint();
     gfx::Point end = center;
     end.Offset(40, 0);
     generator.GestureScrollSequence(center, end,
         base::TimeDelta::FromMilliseconds(100),
         3);
     RunAllPendingInMessageLoop();
 
     EXPECT_FALSE(ash::wm::IsWindowMaximized(window));
     EXPECT_FALSE(ash::wm::IsWindowMinimized(window));
-    // This is a short resizing distance and different touch behavior
-    // applies which leads in half of the screen being used.
-    EXPECT_EQ("400,0 400x552", window->bounds().ToString());
+    gfx::Rect target_bounds = ash::wm::GetSnappedWindowBoundsInParent(
+        window, ash::wm::SNAP_RIGHT_EDGE);
+    EXPECT_EQ(target_bounds.ToString(), window->bounds().ToString());

[Mr4D (OOO till 08-26), 2013/08/29 01:03:15]

again - better tests of results?

[pkotwicz, 2013/08/30 21:10:57]

I think this is good enough for these tests which are mostly for the sake of
sanity. I added SnapSizerTest which tests the actual return value more
thorougly.
(In a similar way, we trust that wm::IsWindowMaximized() is sufficient for
determining if the window is maximized here and do a more thorough test in
ScreenAshTest.Bounds).

   }
 
   // Snap left.
   {
     center = view->GetBoundsInScreen().CenterPoint();
     gfx::Point end = center;
     end.Offset(-40, 0);
     generator.GestureScrollSequence(center, end,
         base::TimeDelta::FromMilliseconds(100),
         3);
     RunAllPendingInMessageLoop();
 
     EXPECT_FALSE(ash::wm::IsWindowMaximized(window));
     EXPECT_FALSE(ash::wm::IsWindowMinimized(window));
-    internal::SnapSizer sizer(window, center,
-        internal::SnapSizer::LEFT_EDGE,
-        internal::SnapSizer::OTHER_INPUT);
-    EXPECT_EQ(sizer.target_bounds().ToString(), window->bounds().ToString());
+    gfx::Rect target_bounds = ash::wm::GetSnappedWindowBoundsInParent(
+        window, ash::wm::SNAP_LEFT_EDGE);
+    EXPECT_EQ(target_bounds.ToString(), window->bounds().ToString());
   }
 
   // Minimize.
   {
     center = view->GetBoundsInScreen().CenterPoint();
     gfx::Point end = center;
     end.Offset(0, 40);
     generator.GestureScrollSequence(center, end,
         base::TimeDelta::FromMilliseconds(100),
         3);
     RunAllPendingInMessageLoop();
 
     EXPECT_TRUE(ash::wm::IsWindowMinimized(window));
   }
 
   // Test with gesture events.
 }
 
-#if defined(OS_WIN)
-// RootWindow and Display can't resize on Windows Ash. http://crbug.com/165962
-#define MAYBE_TouchDragResizeCloseToCornerDiffersFromMouse \
-        DISABLED_TouchDragResizeCloseToCornerDiffersFromMouse
-#else
-#define MAYBE_TouchDragResizeCloseToCornerDiffersFromMouse \
-        TouchDragResizeCloseToCornerDiffersFromMouse
-#endif
-
-// Tests Left/Right snapping with resize button touch dragging - which should
-// trigger dependent on the available drag distance.
-TEST_F(CustomFrameViewAshTest,
-       MAYBE_TouchDragResizeCloseToCornerDiffersFromMouse) {
-  aura::Window* window = widget()->GetNativeWindow();
-  views::View* view = maximize_button();
-
-  gfx::Rect work_area = widget()->GetWorkAreaBoundsInScreen();
-  gfx::Rect bounds = window->bounds();
-  bounds.set_x(work_area.width() - bounds.width());
-  widget()->SetBounds(bounds);
-
-  gfx::Point start_point = view->GetBoundsInScreen().CenterPoint();
-  // We want to move all the way to the right (the few pixels we have).
-  gfx::Point end_point = gfx::Point(work_area.width(), start_point.y());
-
-  aura::test::EventGenerator generator(window->GetRootWindow(), start_point);
-
-  EXPECT_TRUE(ash::wm::IsWindowNormal(window));
-
-  // Snap right with a touch drag.
-  generator.GestureScrollSequence(start_point,
-                                  end_point,
-                                  base::TimeDelta::FromMilliseconds(100),
-                                  10);
-  RunAllPendingInMessageLoop();
-
-  EXPECT_FALSE(ash::wm::IsWindowMaximized(window));
-  EXPECT_FALSE(ash::wm::IsWindowMinimized(window));
-  gfx::Rect touch_result = window->bounds();
-  EXPECT_NE(bounds.ToString(), touch_result.ToString());
-
-  // Set the position back to where it was before and re-try with a mouse.
-  widget()->SetBounds(bounds);
-
-  generator.MoveMouseTo(start_point);
-  generator.PressLeftButton();
-  generator.MoveMouseTo(end_point, 10);
-  generator.ReleaseLeftButton();
-  RunAllPendingInMessageLoop();
-
-  EXPECT_FALSE(ash::wm::IsWindowMaximized(window));
-  EXPECT_FALSE(ash::wm::IsWindowMinimized(window));
-  gfx::Rect mouse_result = window->bounds();
-
-  // The difference between the two operations should be that the mouse
-  // operation should have just started to resize and the touch operation is
-  // already all the way down to the smallest possible size.
-  EXPECT_NE(mouse_result.ToString(), touch_result.ToString());
-  EXPECT_GT(mouse_result.width(), touch_result.width());
-}
-
 // Test that closing the (browser) window with an opened balloon does not
 // crash the system. In other words: Make sure that shutting down the frame
 // destroys the opened balloon in an orderly fashion.
 TEST_F(CustomFrameViewAshTest, MaximizeButtonExternalShutDown) {
   aura::Window* window = widget()->GetNativeWindow();
   ash::FrameMaximizeButton* maximize_button =
       CustomFrameViewAshTest::maximize_button();
   maximize_button->set_bubble_appearance_delay_ms(0);
   gfx::Point button_pos = maximize_button->GetBoundsInScreen().CenterPoint();
   gfx::Point off_pos(button_pos.x() + 100, button_pos.y() + 100);
@@ skipping 103 matching lines @@
       GetButtonForUnitTest(SNAP_LEFT)->GetBoundsInScreen().CenterPoint();
   generator.MoveMouseTo(left_max_pos);
   EXPECT_TRUE(maximize_button->phantom_window_open());
   generator.ClickLeftButton();
 
   EXPECT_FALSE(maximize_button->maximizer());
   EXPECT_FALSE(maximize_button->phantom_window_open());
 
   EXPECT_FALSE(ash::wm::IsWindowMaximized(window));
   EXPECT_FALSE(ash::wm::IsWindowMinimized(window));
-  internal::SnapSizer sizer(window, button_pos,
-                            internal::SnapSizer::LEFT_EDGE,
-                            internal::SnapSizer::OTHER_INPUT);
-  sizer.SelectDefaultSizeAndDisableResize();
-  EXPECT_EQ(sizer.target_bounds().ToString(), window->bounds().ToString());
+  gfx::Rect target_bounds = ash::wm::GetSnappedWindowBoundsInParent(
+      window, ash::wm::SNAP_LEFT_EDGE);
+  EXPECT_EQ(target_bounds.ToString(), window->bounds().ToString());
 }
 
 // Test that the activation focus does not change when the bubble gets shown.
 TEST_F(CustomFrameViewAshTest, MaximizeKeepFocus) {
   aura::Window* window = widget()->GetNativeWindow();
   ash::FrameMaximizeButton* maximize_button =
       CustomFrameViewAshTest::maximize_button();
   maximize_button->set_bubble_appearance_delay_ms(0);
   gfx::Point button_pos = maximize_button->GetBoundsInScreen().CenterPoint();
   gfx::Point off_pos(button_pos.x() + 100, button_pos.y() + 100);
@@ skipping 315 matching lines @@
 
   // Check that there was no size change.
   EXPECT_EQ(widget()->GetWindowBoundsInScreen().size().ToString(),
             initial_bounds.size().ToString());
   // Check that there is no phantom window left open.
   EXPECT_FALSE(maximize_button->phantom_window_open());
 }
 
 }  // namespace test
 }  // namespace ash