Issue 2347073003: [heap] Properly handle --noconcurrent-sweeping flag in page unmapper.

Issue 2347073003: [heap] Properly handle --noconcurrent-sweeping flag in page unmapper. (Closed)

Created:
4 years, 3 months ago by ulan

Modified:
4 years, 3 months ago

Reviewers:
Hannes Payer (out of office)

CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

[heap] Properly handle --noconcurrent-sweeping flag in page unmapper. BUG= Committed: https://crrev.com/72456950c1185a107c6b52cb577da5db00565964 Cr-Commit-Position: refs/heads/master@{#39544}

Created: 4 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -3 lines)			Patch
M	src/heap/incremental-marking.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/heap/mark-compact.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/heap/spaces.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 8 (3 generated)

ulan

PTAL. MemoryAllocator::CanFreeMemoryChunk assumed that concurrent sweeping is always on.

4 years, 3 months ago (2016-09-16 11:09:05 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2347073003/1

4 years, 3 months ago (2016-09-20 10:49:48 UTC) #5

commit-bot: I haz the power

4 years, 3 months ago (2016-09-20 11:17:30 UTC) #8

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/72456950c1185a107c6b52cb577da5db00565964
Cr-Commit-Position: refs/heads/master@{#39544}